Compute API signatures of files.

Compute API signatures of files.

Note, that in non-incemental case this change has negative performance
implications - compilation is 10% slower. Computing MD5 hashes is very
expensive.

In real life scenarios we will cache API signatures and URIs as
part of unlinked information for each file.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/6f4bba5f035ad33a2322e5824d674b12da50a55d

[ahe, 2017-06-08 12:33:12]

lgtm

A random thought and a suggestion to add more information to a comment.

https://codereview.chromium.org/2926883003/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2926883003/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:56: /// It depends on all
non-comment tokens outside the block bodies.
How is the MD5 sum represented? As a byte array? Could you elaborate on this in
the comment?

https://codereview.chromium.org/2926883003/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:131: ScannerResult scanResult
= _scan();
Thinking out loud here, not a review comment:

Since you need the tokens to compute the MD5 sum, I don't think I there's
anything we can tweak in the scanner API.

[scheglov, 2017-06-09 18:40:59]

https://codereview.chromium.org/2926883003/diff/1/pkg/front_end/lib/src/incre...
File pkg/front_end/lib/src/incremental/file_state.dart (right):

https://codereview.chromium.org/2926883003/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:56: /// It depends on all
non-comment tokens outside the block bodies.
On 2017/06/08 12:33:12, ahe wrote:
> How is the MD5 sum represented? As a byte array? Could you elaborate on this
in
> the comment?

Done.

https://codereview.chromium.org/2926883003/diff/1/pkg/front_end/lib/src/incre...
pkg/front_end/lib/src/incremental/file_state.dart:131: ScannerResult scanResult
= _scan();
On 2017/06/08 12:33:12, ahe wrote:
> Thinking out loud here, not a review comment:
> 
> Since you need the tokens to compute the MD5 sum, I don't think I there's
> anything we can tweak in the scanner API.

I don't understand what this means.

[scheglov, 2017-06-09 18:41:35]

Description was changed from

==========
Compute API signatures of files.

Note, that in non-incemental case this change has negative performance
implications - compilation is 10% slower. Computing MD5 hashes is very
expensive.

In real life scenarios we will cache API signatures and URIs as
part of unlinked information for each file.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
==========

to

==========
Compute API signatures of files.

Note, that in non-incemental case this change has negative performance
implications - compilation is 10% slower. Computing MD5 hashes is very
expensive.

In real life scenarios we will cache API signatures and URIs as
part of unlinked information for each file.


R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/6f4bba5f035ad33a2322e5824d674b12da50a55d
==========

[scheglov, 2017-06-09 18:41:36]

Committed patchset #1 (id:1) manually as
6f4bba5f035ad33a2322e5824d674b12da50a55d (presubmit successful).