Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2926863002: Handle parameters in compile_from_dill_test (Closed)
Patch Set: Fixes Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 7b82a582a2a4be1df0279991c652440ac1fb9ce8..57aabba6381bd44df6869b672aa2e354317cf68a 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1035,7 +1035,8 @@ class SsaBuilder extends ast.Visitor
closureToClassMapper.getMemberMap(callee);
localsHandler.closureData = newClosureData;
if (resolvedAst.kind == ResolvedAstKind.PARSED) {
- localsHandler.enterScope(resolvedAst.node,
+ localsHandler.enterScope(
+ newClosureData.capturingScopes[resolvedAst.node],
forGenerativeConstructorBody: callee.isGenerativeConstructorBody);
}
buildInitializers(callee, constructorResolvedAsts, fieldValues);
@@ -1440,7 +1441,18 @@ class SsaBuilder extends ast.Visitor
HBasicBlock block = graph.addNewBlock();
open(graph.entry);
- localsHandler.startFunction(element, node,
+ Map<Local, TypeMask> parameters = <Local, TypeMask>{};
+ if (element is MethodElement) {
+ element.functionSignature
+ .orderedForEachParameter((ParameterElement parameter) {
+ parameters[parameter] = TypeMaskFactory.inferredTypeForParameter(
+ parameter, globalInferenceResults);
+ });
+ }
+
+ ClosureClassMap closureData = closureToClassMapper.getMemberMap(element);
+ localsHandler.startFunction(
+ element, closureData, closureData.capturingScopes[node], parameters,
isGenerativeConstructorBody: element.isGenerativeConstructorBody);
close(new HGoto()).addSuccessor(block);
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart ('k') | pkg/compiler/lib/src/ssa/builder_kernel.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698