ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm - Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.h ('k') | ios/chrome/browser/passwords/password_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

diff --git a/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm b/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

index 0929fcf6a3d8c0f5c0db90208c29af13db33dc4c..19afa4839aba4fabfdd686d7a650b9c790069ccd 100644

--- a/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

+++ b/ios/chrome/browser/passwords/ios_chrome_update_password_infobar_delegate.mm

@@ -27,7 +27,7 @@

void IOSChromeUpdatePasswordInfoBarDelegate::Create(

bool is_smart_lock_branding_enabled,

infobars::InfoBarManager* infobar_manager,

- scoped_refptr<PasswordFormManager> form_manager) {

+ std::unique_ptr<PasswordFormManager> form_manager) {

DCHECK(infobar_manager);

auto delegate = base::WrapUnique(new IOSChromeUpdatePasswordInfoBarDelegate(

is_smart_lock_branding_enabled, std::move(form_manager)));

@@ -43,7 +43,7 @@

IOSChromeUpdatePasswordInfoBarDelegate::IOSChromeUpdatePasswordInfoBarDelegate(

bool is_smart_lock_branding_enabled,

- scoped_refptr<PasswordFormManager> form_manager)

+ std::unique_ptr<PasswordFormManager> form_manager)

: IOSChromePasswordManagerInfoBarDelegate(is_smart_lock_branding_enabled,

std::move(form_manager)) {

selected_account_ = form_to_save()->preferred_match()->username_value;