components/password_manager/core/browser/credential_manager_password_form_manager.cc - Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/credential_manager_password_form_manager.cc

Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/credential_manager_password_form_manager.h ('k') | components/password_manager/core/browser/credential_manager_password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/credential_manager_password_form_manager.cc

diff --git a/components/password_manager/core/browser/credential_manager_password_form_manager.cc b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

index ffdeb11a5278c3f227e789a408ddfdf83f6a0f72..4406d199befce93e1b68dcb05f56c52dc476a1d0 100644

--- a/components/password_manager/core/browser/credential_manager_password_form_manager.cc

+++ b/components/password_manager/core/browser/credential_manager_password_form_manager.cc

@@ -45,6 +45,9 @@

GrabFetcher(std::move(form_fetcher));

}

+CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {

void CredentialManagerPasswordFormManager::ProcessMatches(

const std::vector<const PasswordForm*>& non_federated,

size_t filtered_count) {

@@ -65,8 +68,6 @@

weak_factory_.GetWeakPtr()));

}

-CredentialManagerPasswordFormManager::~CredentialManagerPasswordFormManager() {}

void CredentialManagerPasswordFormManager::NotifyDelegate() {

delegate_->OnProvisionalSaveComplete();

}