chrome/browser/password_manager/update_password_infobar_delegate_android.h - Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/update_password_infobar_delegate_android.h

Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate_android_unittest.cc ('k') | chrome/browser/password_manager/update_password_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/update_password_infobar_delegate_android.h

diff --git a/chrome/browser/password_manager/update_password_infobar_delegate_android.h b/chrome/browser/password_manager/update_password_infobar_delegate_android.h

index b759f8076442a6401d69e8b94400c9eab35df9f0..7bdf489e4419563ff262cb2bf5e643529a6d2536 100644

--- a/chrome/browser/password_manager/update_password_infobar_delegate_android.h

+++ b/chrome/browser/password_manager/update_password_infobar_delegate_android.h

@@ -9,7 +9,6 @@

#include <vector>

#include "base/macros.h"

-#include "base/memory/ref_counted.h"

#include "chrome/browser/password_manager/password_manager_infobar_delegate_android.h"

#include "chrome/browser/ui/passwords/manage_passwords_state.h"

#include "components/password_manager/core/browser/password_form_manager.h"

@@ -27,7 +26,7 @@

public:

static void Create(

content::WebContents* web_contents,

- scoped_refptr<password_manager::PasswordFormManager> form_to_update);

+ std::unique_ptr<password_manager::PasswordFormManager> form_to_update);

~UpdatePasswordInfoBarDelegate() override;

@@ -55,7 +54,7 @@

private:

UpdatePasswordInfoBarDelegate(

content::WebContents* web_contents,

- scoped_refptr<password_manager::PasswordFormManager> form_to_update,

+ std::unique_ptr<password_manager::PasswordFormManager> form_to_update,

bool is_smartlock_branding_enabled);

// ConfirmInfoBarDelegate: