Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.h

Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.h b/chrome/browser/ui/passwords/manage_passwords_state.h
index 03a7a1b6d7fcfe48f29e2f6e28d27a44eb350cb9..62de5447b4da34f8fa56b890ec47e2032c69d3f3 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.h
+++ b/chrome/browser/ui/passwords/manage_passwords_state.h
@@ -11,7 +11,6 @@
#include "base/callback.h"
#include "base/macros.h"
-#include "base/memory/ref_counted.h"
#include "base/strings/string16.h"
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/password_store_change.h"
@@ -45,11 +44,11 @@
// Move to PENDING_PASSWORD_STATE.
void OnPendingPassword(
- scoped_refptr<password_manager::PasswordFormManager> form_manager);
+ std::unique_ptr<password_manager::PasswordFormManager> form_manager);
// Move to PENDING_PASSWORD_UPDATE_STATE.
void OnUpdatePassword(
- scoped_refptr<password_manager::PasswordFormManager> form_manager);
+ std::unique_ptr<password_manager::PasswordFormManager> form_manager);
// Move to CREDENTIAL_REQUEST_STATE.
void OnRequestCredentials(
@@ -63,7 +62,7 @@
// Move to CONFIRMATION_STATE.
void OnAutomaticPasswordSave(
- scoped_refptr<password_manager::PasswordFormManager> form_manager);
+ std::unique_ptr<password_manager::PasswordFormManager> form_manager);
// Move to MANAGE_STATE or INACTIVE_STATE for PSL matched passwords.
// |password_form_map| contains best matches from the password store for the
@@ -128,7 +127,7 @@
GURL origin_;
// Contains the password that was submitted.
- scoped_refptr<password_manager::PasswordFormManager> form_manager_;
+ std::unique_ptr<password_manager::PasswordFormManager> form_manager_;
// Contains all the current forms.
std::vector<std::unique_ptr<autofill::PasswordForm>> local_credentials_forms_;

Powered by Google App Engine
This is Rietveld 408576698