components/password_manager/content/browser/credential_manager_impl_unittest.cc - Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl_unittest.cc

Issue 2926833002: Revert of [Password Manager] Convert |pending_login_managers_| to an array of scoped_refptr (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl.cc ('k') | components/password_manager/core/browser/credential_manager_password_form_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl_unittest.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl_unittest.cc b/components/password_manager/content/browser/credential_manager_impl_unittest.cc

index 5feb29ed613e2dd35e558f5f6d2a5e7926184c1a..0e7a132ff74b5ff8c2ac9b886c4178ef1c106040 100644

--- a/components/password_manager/content/browser/credential_manager_impl_unittest.cc

+++ b/components/password_manager/content/browser/credential_manager_impl_unittest.cc

@@ -81,7 +81,7 @@

~MockPasswordManagerClient() override {}

bool PromptUserToSaveOrUpdatePassword(

- scoped_refptr<PasswordFormManager> manager,

+ std::unique_ptr<PasswordFormManager> manager,

bool update_password) override {

manager_.swap(manager);

PromptUserToSavePasswordPtr(manager_.get());

@@ -136,7 +136,7 @@

private:

TestingPrefServiceSimple prefs_;

PasswordStore* store_;

- scoped_refptr<PasswordFormManager> manager_;

+ std::unique_ptr<PasswordFormManager> manager_;

DISALLOW_COPY_AND_ASSIGN(MockPasswordManagerClient);

};