Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1427)

Issue 292683002: Remove --echo-ext-path flag (Closed)

Created:
6 years, 7 months ago by gauravsh
Modified:
6 years, 7 months ago
Reviewers:
Finnur, oscarpan1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Remove --echo-ext-path flag This flag is no longer used. BUG=352747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271550

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/extensions/component_loader.cc View 1 1 chunk +2 lines, -7 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gauravsh
@finnur: Please review (+ OWNERS). @oscarpan: FYI
6 years, 7 months ago (2014-05-17 17:36:19 UTC) #1
Finnur
LGTM. Peter Kasting sent out a doc listing flags to be removed. Can you see ...
6 years, 7 months ago (2014-05-19 11:25:14 UTC) #2
gauravsh
Yes, I already did.
6 years, 7 months ago (2014-05-19 15:36:25 UTC) #3
gauravsh
The CQ bit was checked by gauravsh@chromium.org
6 years, 7 months ago (2014-05-19 15:36:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/292683002/1
6 years, 7 months ago (2014-05-19 15:36:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 17:17:37 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 17:21:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/26423) linux_chromium_gn_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel/builds/8296) linux_chromium_rel ...
6 years, 7 months ago (2014-05-19 17:21:33 UTC) #8
gauravsh
The CQ bit was checked by gauravsh@chromium.org
6 years, 7 months ago (2014-05-19 23:36:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/292683002/20001
6 years, 7 months ago (2014-05-19 23:36:53 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 03:01:12 UTC) #11
Message was sent while issue was closed.
Change committed as 271550

Powered by Google App Engine
This is Rietveld 408576698