Introduce LocalCaretRect for refactoring Local{Caret,Selection}RectPosition()

third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleUnits.h"
 
 #include <ostream>  // NOLINT
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/dom/Text.h"
 #include "core/editing/EditingTestBase.h"
@@ skipping 1070 matching lines @@
 TEST_F(VisibleUnitsTest, localCaretRectOfPosition) {
   const char* body_content =
       "<p id='host'><b id='one'>1</b></p><b id='two'>22</b>";
   const char* shadow_content =
       "<b id='two'>22</b><content select=#one></content><b id='three'>333</b>";
   SetBodyContent(body_content);
   SetShadowContent(shadow_content, "host");
 
   Element* one = GetDocument().getElementById("one");
 
-  LayoutObject* layout_object_from_dom_tree;
-  LayoutRect layout_rect_from_dom_tree = LocalCaretRectOfPosition(
-      Position(one->firstChild(), 0), layout_object_from_dom_tree);
+  const LocalCaretRect& caret_rect_from_dom_tree =
+      LocalCaretRectOfPosition(Position(one->firstChild(), 0));
 
-  LayoutObject* layout_object_from_flat_tree;
-  LayoutRect layout_rect_from_flat_tree = LocalCaretRectOfPosition(
-      PositionInFlatTree(one->firstChild(), 0), layout_object_from_flat_tree);
+  const LocalCaretRect& caret_rect_from_flat_tree =
+      LocalCaretRectOfPosition(PositionInFlatTree(one->firstChild(), 0));
 
-  EXPECT_TRUE(layout_object_from_dom_tree);
-  EXPECT_FALSE(layout_rect_from_dom_tree.IsEmpty());
-  EXPECT_EQ(layout_object_from_dom_tree, layout_object_from_flat_tree);
-  EXPECT_EQ(layout_rect_from_dom_tree, layout_rect_from_flat_tree);
+  EXPECT_FALSE(caret_rect_from_dom_tree.IsEmpty());
+  EXPECT_EQ(caret_rect_from_dom_tree.layout_object,
+            caret_rect_from_flat_tree.layout_object);
+  EXPECT_EQ(caret_rect_from_dom_tree.rect, caret_rect_from_flat_tree.rect);
 }
 
 TEST_F(VisibleUnitsTest, logicalEndOfLine) {
   const char* body_content =
       "<a id=host><b id=one>11</b><b id=two>22</b></a><i id=three>333</i><i "
       "id=four>4444</i><br>";
   const char* shadow_content =
       "<div><u id=five>55555</u><content select=#two></content><br><u "
       "id=six>666666</u><br><content select=#one></content><u "
       "id=seven>7777777</u></div>";
@@ skipping 876 matching lines @@
        canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter) {
   SetBodyContent("<p>  &#x20E3;</p>");  // Leading space is necessary
 
   Node* paragraph = GetDocument().QuerySelector("p");
   Node* text = paragraph->firstChild();
   Position start = CanonicalPositionOf(Position::BeforeNode(paragraph));
   EXPECT_EQ(Position(text, 2), start);
 }
 
 }  // namespace blink