Add support for repeated keys in TaskRequest.

appengine/swarming/server/task_scheduler.py

 # Copyright 2014 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 """High level tasks execution scheduling API.
 
 This is the interface closest to the HTTP handlers.
 """
 
 import datetime
@@ skipping 332 matching lines @@
   """Raises AuthorizationError if some requested dimensions are forbidden.
 
   Uses 'dimension_acls' field from the settings. See proto/config.proto.
   """
   dim_acls = config.settings().dimension_acls
   if not dim_acls or not dim_acls.entry:
     return # not configured, this is fine
 
   ident = request.authenticated
   dims = request.properties.dimensions
-  assert 'id' in dims or 'pool' in dims, dims # see _validate_dimensions
   assert ident is not None # see task_request.init_new_request
 
+  using_id = any(k == u'id' for k, _ in dims)
+  using_pool = any(k == u'pool' for k, _ in dims)
   # Forbid targeting individual bots for non-admins, but allow using 'id' if
   # 'pool' is used as well (so whoever can posts tasks to 'pool', can target an
   # individual bot in that pool).
-  if 'id' in dims and 'pool' not in dims:
+  if using_id and not using_pool:
     if not acl.is_admin():
       raise auth.AuthorizationError(
           'Only Swarming administrators can post tasks with "id" dimension '
           'without specifying a "pool" dimension.')
 
-  for k, v in sorted(dims.iteritems()):
+  for k, v in dims:
     if not _can_use_dimension(dim_acls, ident, k, v):
       raise auth.AuthorizationError(
           'User %s is not allowed to schedule tasks with dimension "%s:%s"' %
           (ident.to_bytes(), k, v))
 
 
 def _can_use_dimension(dim_acls, ident, k, v):
   """Returns True if 'dimension_acls' allow the given dimension to be used.
 
   Args:
@@ skipping 554 matching lines @@
 ## Task queue tasks.
 
 
 def task_handle_pubsub_task(payload):
   """Handles task enqueued by _maybe_pubsub_notify_via_tq."""
   # Do not catch errors to trigger task queue task retry. Errors should not
   # happen in normal case.
   _pubsub_notify(
       payload['task_id'], payload['topic'],
       payload['auth_token'], payload['userdata'])