Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1074)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/toolbar/toolbar_model_delegate.h

Issue 2926703002: Remove VectorIconId references from the codebase (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/system/palette/palette_tool_manager.h ('K') | « components/omnibox/browser/omnibox_view.h ('k') | ui/gfx/vector_icon_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/toolbar/toolbar_model_delegate.h
diff --git a/components/toolbar/toolbar_model_delegate.h b/components/toolbar/toolbar_model_delegate.h
index 8c61c451bec30739ac5428a4d93390ab7ef6771e..54553b26cc34c7def7478b45deff8592393a1c26 100644
--- a/components/toolbar/toolbar_model_delegate.h
+++ b/components/toolbar/toolbar_model_delegate.h
@@ -51,9 +51,9 @@ class ToolbarModelDelegate {
virtual bool FailsMalwareCheck() const = 0;
// Returns the id of the icon to show to the left of the address, or
- // gfx::VectorIconId::VECTOR_ICON_NONE if the icon should be selected by the
- // caller. This is useful for associating particular URLs with particular
- // schemes without importing knowledge of those schemes into this component.
+ // gfx::kNoneIcon if the icon should be selected by the caller. This is useful
Evan Stade 2017/06/06 21:28:57 are you sure it doesn't return null?
tdanderson 2017/06/07 15:55:55 Done.
+ // for associating particular URLs with particular schemes without importing
+ // knowledge of those schemes into this component.
virtual const gfx::VectorIcon* GetVectorIconOverride() const = 0;
protected:
« ash/system/palette/palette_tool_manager.h ('K') | « components/omnibox/browser/omnibox_view.h ('k') | ui/gfx/vector_icon_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698