Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: tools/perf/page_sets/startup_pages.py

Issue 2926673002: Explicitly setting story names for start_with_* benchmarks (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/page_sets/blank_page_with_extension_profile.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/startup_pages.py
diff --git a/tools/perf/page_sets/startup_pages.py b/tools/perf/page_sets/startup_pages.py
index 59322bc0bbdb4e802f98c850478fee4a9ba37bba..0b6327d8f11f750b9aec610da2a287361c9af3b2 100644
--- a/tools/perf/page_sets/startup_pages.py
+++ b/tools/perf/page_sets/startup_pages.py
@@ -23,7 +23,8 @@ class StartedPage(page_module.Page):
def __init__(self, url, page_set):
super(StartedPage, self).__init__(
url=url, page_set=page_set, startup_url=url,
- shared_page_state_class=BrowserStartupSharedState)
+ shared_page_state_class=BrowserStartupSharedState,
+ name=url)
self.archive_data_file = 'data/startup_pages.json'
def RunNavigateSteps(self, action_runner):
@@ -47,7 +48,8 @@ class StartupPagesPageSet(story.StorySet):
def __init__(self):
super(StartupPagesPageSet, self).__init__(
archive_data_file='data/startup_pages.json',
- cloud_storage_bucket=story.PARTNER_BUCKET)
+ cloud_storage_bucket=story.PARTNER_BUCKET,
+ verify_names=True)
# Typical page.
self.AddStory(StartedPage('about:blank', self))
« no previous file with comments | « tools/perf/page_sets/blank_page_with_extension_profile.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698