[GRC] Coordination Unit Graph Observer

services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc

Index: services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc
diff --git a/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc b/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc
index bbc72b6209cef201d3f6975c879d70923ff5e87a..46810d762c0ccc98274b8f497c3881142b268953 100644
--- a/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc
+++ b/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc
@@ -10,14 +10,17 @@
 #include "base/macros.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 #include "services/resource_coordinator/coordination_unit/coordination_unit_factory.h"
+#include "services/resource_coordinator/coordination_unit/coordination_unit_graph_observer.h"
 #include "services/resource_coordinator/coordination_unit/coordination_unit_impl.h"
 #include "services/service_manager/public/cpp/service_context_ref.h"
 
 namespace resource_coordinator {
 
 CoordinationUnitProviderImpl::CoordinationUnitProviderImpl(
-    service_manager::ServiceContextRefFactory* service_ref_factory)
-    : service_ref_factory_(service_ref_factory) {
+    service_manager::ServiceContextRefFactory* service_ref_factory,
+    CoordinationUnitManager* coordination_unit_manager)
+    : service_ref_factory_(service_ref_factory),
+      coordination_unit_manager_(coordination_unit_manager) {
   DCHECK(service_ref_factory);
   service_ref_ = service_ref_factory->CreateRef();
 }
@@ -31,17 +34,29 @@ void CoordinationUnitProviderImpl::CreateCoordinationUnit(
       coordination_unit_factory::CreateCoordinationUnit(
           id, service_ref_factory_->CreateRef());
 
-  mojo::MakeStrongBinding(std::move(coordination_unit), std::move(request));
+  CoordinationUnitImpl* coordination_unit_impl = coordination_unit.get();
+
+  auto coordination_unit_binding =
+      mojo::MakeStrongBinding(std::move(coordination_unit), std::move(request));
+
+  coordination_unit_manager_->NotifyObserversCoordinationUnitCreated(

[Zhen Wang, 2017/06/15 20:07:53]

Why not call the notify function in CoordinationUnitImpl's constructor? Does it
require binding setup?

[matthalp, 2017/06/16 16:14:25]

oysteine@ and I discussed whether or not to put the NotifyObservers* in the
constructor or destructor. Additionally, the CoordinationUnitImpls can be
derived so this ensures that any derived constructors can make their
modifications before the observers are called.

+      coordination_unit_impl);
+
+  coordination_unit_binding->set_connection_error_handler(base::Bind(
+      &CoordinationUnitManager::NotifyObserversCoordinationUnitWillBeDestroyed,
+      base::Unretained(coordination_unit_manager_),
+      base::Unretained(coordination_unit_impl)));
 }
 
 // static
 void CoordinationUnitProviderImpl::Create(
     service_manager::ServiceContextRefFactory* service_ref_factory,
+    CoordinationUnitManager* coordination_unit_manager,
     const service_manager::BindSourceInfo& source_info,
     resource_coordinator::mojom::CoordinationUnitProviderRequest request) {
-  mojo::MakeStrongBinding(
-      base::MakeUnique<CoordinationUnitProviderImpl>(service_ref_factory),
-      std::move(request));
+  mojo::MakeStrongBinding(base::MakeUnique<CoordinationUnitProviderImpl>(
+                              service_ref_factory, coordination_unit_manager),
+                          std::move(request));
 }
 
 }  // namespace resource_coordinator