[GRC] Coordination Unit Graph Observer

services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/resource_coordinator/coordination_unit/coordination_unit_impl_unittest_util.h"
 
 #include "base/bind.h"
 #include "base/run_loop.h"
 
 namespace resource_coordinator {
 
 namespace {
 
 void OnLastServiceRefDestroyed() {
   // No-op. This is required by service_manager::ServiceContextRefFactory
   // construction but not needed for the tests.
 }
 
 }  // namespace
 
 CoordinationUnitImplTestBase::CoordinationUnitImplTestBase()
     : service_ref_factory_(base::Bind(&OnLastServiceRefDestroyed)),
-      provider_(&service_ref_factory_) {}
+      provider_(&service_ref_factory_, &coordination_unit_manager_) {
+  // Ensure tests only include the observers that are needed instead
+  // of what is registered by default to run in a browser instance.
+  coordination_unit_manager_.UnregisterAllObserversForTesting();

[Zhen Wang, 2017/06/15 20:07:53]

Is there another test helper class that can include the default ones? I am not
sure if we need those for integration test or something similar.

[matthalp, 2017/06/16 00:01:27]

I have gone ahead and removed this function. Instead,
CoordinationUnitManager::Register can be called within the
ResourceCoordinatorService constructor, which owns CoordinationUnitManager
throughout it's lifetime (i.e. the ResourceCoordinatorService's lifetime).

The comment about registering an observer in CoordinationUnitGraphObserver has
been updated.

+}
 
 CoordinationUnitImplTestBase::~CoordinationUnitImplTestBase() = default;
 
 void CoordinationUnitImplTestBase::TearDown() {
   base::RunLoop().RunUntilIdle();
 }
 
 }  // namespace resource_coordinator