Issue 2926663002: Reapply (plus add some more) Entity-ify some portions of LocalsHandler and Closure.

Issue 2926663002: Reapply (plus add some more) Entity-ify some portions of LocalsHandler and Closure. (Closed)

Created:
3 years, 6 months ago by Emily Fortuna

Modified:
3 years, 6 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, ahe

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Revert "Entity-ify some portions of LocalsHandler and Closure."" This reverts commit cdb41f9258376ab48f694021dc8869f1c8c5b7b8. Peter pointed out this caused a few analyzer errors. My "best tests" clearly fell short. BUG= R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/c6195b03f6c65d1aafc68ac2d4ddf3dbea31cadf

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -37 lines)			Patch
M	pkg/compiler/lib/src/closure.dart	View		6 chunks	+7 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/inferrer_engine.dart	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/locals_handler.dart	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/locals_handler.dart	View		5 chunks	+6 lines, -8 lines	0 comments	Download
M	tests/compiler/dart2js/serialization/model_test_helper.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (3 generated)

Emily Fortuna

Committed patchset #2 (id:20001) manually as c6195b03f6c65d1aafc68ac2d4ddf3dbea31cadf (presubmit successful).

3 years, 6 months ago (2017-06-06 20:34:29 UTC) #6

Message was sent while issue was closed.

lgtm