Explicitly setting story names for all smoothness benchmarks

tools/perf/page_sets/tough_pinch_zoom_cases.py

Index: tools/perf/page_sets/tough_pinch_zoom_cases.py
diff --git a/tools/perf/page_sets/tough_pinch_zoom_cases.py b/tools/perf/page_sets/tough_pinch_zoom_cases.py
index 2aa01516ef9ea5d518285eb3c75b068fee59dbbc..371870e272425ef283a5c79c5983d6869e5c4f60 100644
--- a/tools/perf/page_sets/tough_pinch_zoom_cases.py
+++ b/tools/perf/page_sets/tough_pinch_zoom_cases.py
@@ -9,6 +9,8 @@ from telemetry import story
 class ToughPinchZoomCasesPage(page_module.Page):
 
   def __init__(self, url, page_set, name=''):
+    if name == '':
+      name = url

[bokan, 2017/06/06 20:12:10]

Not sure I understand, this looks to me to be the opposite of what the commit
message and bug describe.

From the bug: "We do not currently always explicitly set the name of stories in
story sets. It then defaults to using the URL". Isn't this what the bug is
trying to get away from?

[ashleymarie1, 2017/06/06 20:35:00]

Sorry for the confusion. The goal of the bug is to push name generation logic
out of telemetry and into story initialization. Right now, there are 5+ ways
that telemetry identifies a story: name, url, id, display_name, etc. We'd like
to pull that back into one or two ways. display_name does a lot of funky stuff
to come up with a reasonable name for a nameless story so we're gonna kill off
that logic and just require all stories have names. If story sets want to
generate page names dynamically, that is fine. We just don't want to do it on
the telemetry side.

[bokan, 2017/06/06 20:45:08]

Got it, thanks for the explanation!

     super(ToughPinchZoomCasesPage, self).__init__(
         url=url, page_set=page_set, name=name,
         shared_page_state_class=shared_page_state.SharedDesktopPageState,
@@ -216,7 +218,8 @@ class ToughPinchZoomCasesPageSet(story.StorySet):
   def __init__(self, target_scale_factor):
     super(ToughPinchZoomCasesPageSet, self).__init__(
       archive_data_file='data/tough_pinch_zoom_cases.json',
-      cloud_storage_bucket=story.PARTNER_BUCKET)
+      cloud_storage_bucket=story.PARTNER_BUCKET,
+      verify_names=True)
 
     self.target_scale_factor = target_scale_factor