Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: tools/perf/page_sets/image_decoding_cases.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)
Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/image_decoding_cases.py
diff --git a/tools/perf/page_sets/image_decoding_cases.py b/tools/perf/page_sets/image_decoding_cases.py
index dd1eb7e6e063dceb46a88c34d7515d01339ebafb..de7daa11b8726a501945928e8fd3d9db527350eb 100644
--- a/tools/perf/page_sets/image_decoding_cases.py
+++ b/tools/perf/page_sets/image_decoding_cases.py
@@ -6,8 +6,9 @@ from telemetry import story
class ImageDecodingCasesPage(page_module.Page):
- def __init__(self, url, page_set):
- super(ImageDecodingCasesPage, self).__init__(url=url, page_set=page_set)
+ def __init__(self, url, page_set, name):
+ super(ImageDecodingCasesPage, self).__init__(
+ url=url, page_set=page_set, name=name)
def RunPageInteractions(self, action_runner):
with action_runner.CreateInteraction('DecodeImage'):
@@ -18,11 +19,11 @@ class ImageDecodingCasesPageSet(story.StorySet):
""" A directed benchmark of accelerated jpeg image decoding performance """
def __init__(self):
- super(ImageDecodingCasesPageSet, self).__init__()
+ super(ImageDecodingCasesPageSet, self).__init__(verify_names=True)
urls_list = [
'file://image_decoding_cases/yuv_decoding.html'
]
for url in urls_list:
- self.AddStory(ImageDecodingCasesPage(url, self))
+ self.AddStory(ImageDecodingCasesPage(url, self, name='yuv_decoding.html'))
cblume 2017/06/06 20:10:58 The only url in the urls_list is yuv_decoding. Thi
ashleymarie1 2017/06/06 20:35:00 Good point! I update the urls_list to be a list of
« no previous file with comments | « no previous file | tools/perf/page_sets/key_desktop_move_cases.py » ('j') | tools/perf/page_sets/key_desktop_move_cases.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698