tools/perf/page_sets/tough_pinch_zoom_cases.py - Issue 2926633002: Explicitly setting story names for all smoothness benchmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/tough_pinch_zoom_cases.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)

Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/page_sets/tough_pinch_zoom_cases.py

diff --git a/tools/perf/page_sets/tough_pinch_zoom_cases.py b/tools/perf/page_sets/tough_pinch_zoom_cases.py

index 2aa01516ef9ea5d518285eb3c75b068fee59dbbc..371870e272425ef283a5c79c5983d6869e5c4f60 100644

--- a/tools/perf/page_sets/tough_pinch_zoom_cases.py

+++ b/tools/perf/page_sets/tough_pinch_zoom_cases.py

@@ -9,6 +9,8 @@ from telemetry import story

class ToughPinchZoomCasesPage(page_module.Page):

def __init__(self, url, page_set, name=''):

+ if name == '':

+ name = url

super(ToughPinchZoomCasesPage, self).__init__(

url=url, page_set=page_set, name=name,

shared_page_state_class=shared_page_state.SharedDesktopPageState,

@@ -216,7 +218,8 @@ class ToughPinchZoomCasesPageSet(story.StorySet):

def __init__(self, target_scale_factor):

super(ToughPinchZoomCasesPageSet, self).__init__(

archive_data_file='data/tough_pinch_zoom_cases.json',

- cloud_storage_bucket=story.PARTNER_BUCKET)

+ cloud_storage_bucket=story.PARTNER_BUCKET,

+ verify_names=True)

self.target_scale_factor = target_scale_factor