Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: tools/perf/page_sets/tough_path_rendering_cases.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)
Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/tough_path_rendering_cases.py
diff --git a/tools/perf/page_sets/tough_path_rendering_cases.py b/tools/perf/page_sets/tough_path_rendering_cases.py
index b8b4dd912ca59ad02f638a36ac8493a417b970b3..53dde986f977fe30bf8c845940b5544843cabcf0 100644
--- a/tools/perf/page_sets/tough_path_rendering_cases.py
+++ b/tools/perf/page_sets/tough_path_rendering_cases.py
@@ -28,7 +28,8 @@ class ToughPathRenderingCasesPageSet(story.StorySet):
def __init__(self):
super(ToughPathRenderingCasesPageSet, self).__init__(
archive_data_file='data/tough_path_rendering_cases.json',
- cloud_storage_bucket=story.PARTNER_BUCKET)
+ cloud_storage_bucket=story.PARTNER_BUCKET,
+ verify_names=True)
page_list = [
('GUIMark Vector Chart Test',
@@ -45,5 +46,6 @@ class ToughPathRenderingCasesPageSet(story.StorySet):
# Chalkboard content linked from
# http://ie.microsoft.com/testdrive/Performance/Chalkboard/.
- self.AddStory(ChalkboardPage(
- 'https://testdrive-archive.azurewebsites.net/performance/chalkboard/', self))
+ chalkboard_url = ('https://testdrive-archive.azurewebsites.net'
+ '/performance/chalkboard/')
+ self.AddStory(ChalkboardPage(chalkboard_url, self, name=chalkboard_url))
Stephen White 2017/06/07 13:29:30 Same here: display name should be "IE Chalkboard".
ashleymarie1 2017/06/07 20:52:51 Done.

Powered by Google App Engine
This is Rietveld 408576698