Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: tools/perf/page_sets/maps.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)
Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.page import page as page_module 5 from telemetry.page import page as page_module
6 from telemetry import story 6 from telemetry import story
7 7
8 from page_sets import webgl_supported_shared_state 8 from page_sets import webgl_supported_shared_state
9 9
10 10
11 class MapsPage(page_module.Page): 11 class MapsPage(page_module.Page):
12 12
13 def __init__(self, page_set): 13 def __init__(self, page_set):
14 super(MapsPage, self).__init__( 14 super(MapsPage, self).__init__(
15 url='http://localhost:8000/performance.html', 15 url='http://localhost:8000/performance.html',
16 page_set=page_set, 16 page_set=page_set,
17 shared_page_state_class=( 17 shared_page_state_class=(
18 webgl_supported_shared_state.WebGLSupportedSharedState)) 18 webgl_supported_shared_state.WebGLSupportedSharedState),
19 name='http://localhost:8000/performance.html')
cblume 2017/06/06 20:10:58 I am bad at python but is there a way to have both
ashleymarie1 2017/06/06 20:35:00 Done.
19 self.archive_data_file = 'data/maps.json' 20 self.archive_data_file = 'data/maps.json'
20 21
21 @property 22 @property
22 def skipped_gpus(self): 23 def skipped_gpus(self):
23 # Skip this intensive test on low-end devices. crbug.com/464731 24 # Skip this intensive test on low-end devices. crbug.com/464731
24 return ['arm'] 25 return ['arm']
25 26
26 def RunNavigateSteps(self, action_runner): 27 def RunNavigateSteps(self, action_runner):
27 super(MapsPage, self).RunNavigateSteps(action_runner) 28 super(MapsPage, self).RunNavigateSteps(action_runner)
28 action_runner.Wait(3) 29 action_runner.Wait(3)
29 30
30 def RunPageInteractions(self, action_runner): 31 def RunPageInteractions(self, action_runner):
31 with action_runner.CreateInteraction('MapAnimation'): 32 with action_runner.CreateInteraction('MapAnimation'):
32 action_runner.WaitForJavaScriptCondition( 33 action_runner.WaitForJavaScriptCondition(
33 'window.testMetrics != undefined', timeout=120) 34 'window.testMetrics != undefined', timeout=120)
34 35
35 36
36 class MapsPageSet(story.StorySet): 37 class MapsPageSet(story.StorySet):
37 38
38 """ Google Maps examples """ 39 """ Google Maps examples """
39 40
40 def __init__(self): 41 def __init__(self):
41 super(MapsPageSet, self).__init__( 42 super(MapsPageSet, self).__init__(
42 archive_data_file='data/maps.json', 43 archive_data_file='data/maps.json',
43 cloud_storage_bucket=story.PUBLIC_BUCKET) 44 cloud_storage_bucket=story.PUBLIC_BUCKET,
45 verify_names=True)
44 46
45 self.AddStory(MapsPage(self)) 47 self.AddStory(MapsPage(self))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698