Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: tools/perf/page_sets/key_silk_cases.py

Issue 2926633002: Explicitly setting story names for all smoothness benchmarks (Closed)
Patch Set: Explicitly setting story names for all smoothness benchmarks Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 from telemetry.page import page as page_module 4 from telemetry.page import page as page_module
5 from telemetry.page import shared_page_state 5 from telemetry.page import shared_page_state
6 from telemetry import story 6 from telemetry import story
7 7
8 8
9 class KeySilkCasesPage(page_module.Page): 9 class KeySilkCasesPage(page_module.Page):
10 10
11 def __init__(self, url, page_set, run_no_page_interactions): 11 def __init__(self, url, page_set, run_no_page_interactions):
12 """ Base class for all key silk cases pages. 12 """ Base class for all key silk cases pages.
13 13
14 Args: 14 Args:
15 run_no_page_interactions: whether the page will run any interactions after 15 run_no_page_interactions: whether the page will run any interactions after
16 navigate steps. 16 navigate steps.
17 """ 17 """
18 super(KeySilkCasesPage, self).__init__( 18 super(KeySilkCasesPage, self).__init__(
19 url=url, page_set=page_set, credentials_path = 'data/credentials.json', 19 url=url, page_set=page_set, credentials_path = 'data/credentials.json',
20 shared_page_state_class=shared_page_state.SharedMobilePageState) 20 shared_page_state_class=shared_page_state.SharedMobilePageState)
21
21 self.archive_data_file = 'data/key_silk_cases.json' 22 self.archive_data_file = 'data/key_silk_cases.json'
22 self._run_no_page_interactions = run_no_page_interactions 23 self._run_no_page_interactions = run_no_page_interactions
23 24
24 def RunNavigateSteps(self, action_runner): 25 def RunNavigateSteps(self, action_runner):
25 super(KeySilkCasesPage, self).RunNavigateSteps(action_runner) 26 super(KeySilkCasesPage, self).RunNavigateSteps(action_runner)
26 action_runner.Wait(2) 27 action_runner.Wait(2)
27 28
28 def RunPageInteractions(self, action_runner): 29 def RunPageInteractions(self, action_runner):
29 # If a key silk case page wants to customize it actions, it should 30 # If a key silk case page wants to customize it actions, it should
30 # overrides the PerformPageInteractions method instead of this method. 31 # overrides the PerformPageInteractions method instead of this method.
(...skipping 728 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 self.AddStory(SilkFinance(self, run_no_page_interactions)) 760 self.AddStory(SilkFinance(self, run_no_page_interactions))
760 # Flaky interaction steps on Android; crbug.com/507865 761 # Flaky interaction steps on Android; crbug.com/507865
761 # self.AddStory(PolymerTopeka(self, run_no_page_interactions)) 762 # self.AddStory(PolymerTopeka(self, run_no_page_interactions))
762 self.AddStory(Masonry(self, run_no_page_interactions)) 763 self.AddStory(Masonry(self, run_no_page_interactions))
763 764
764 for page in self: 765 for page in self:
765 assert (page.__class__.RunPageInteractions == 766 assert (page.__class__.RunPageInteractions ==
766 KeySilkCasesPage.RunPageInteractions), ( 767 KeySilkCasesPage.RunPageInteractions), (
767 'Pages in this page set must not override KeySilkCasesPage\' ' 768 'Pages in this page set must not override KeySilkCasesPage\' '
768 'RunPageInteractions method.') 769 'RunPageInteractions method.')
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698