Explicitly setting story names for all smoothness benchmarks

tools/perf/page_sets/key_desktop_move_cases.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 from telemetry.page import page as page_module
 from telemetry.page import shared_page_state
 from telemetry import story
 
 
 class KeyDesktopMoveCasesPage(page_module.Page):
 
   def __init__(self, url, page_set, name='', credentials=None):
+    if name == '':
+      name = url
     super(KeyDesktopMoveCasesPage, self).__init__(
         url=url, page_set=page_set, name=name,
         credentials_path='data/credentials.json',
         shared_page_state_class=shared_page_state.SharedDesktopPageState)
     self.archive_data_file = 'data/key_desktop_move_cases.json'
     self.credentials = credentials
 
 
 class GmailMouseScrollPage(KeyDesktopMoveCasesPage):
 
@@ skipping 87 matching lines @@
     # TODO(ssid): Add zoom gestures after fixing bug crbug.com/462214.
 
 
 class KeyDesktopMoveCasesPageSet(story.StorySet):
 
   """ Special cases for move gesture """
 
   def __init__(self):
     super(KeyDesktopMoveCasesPageSet, self).__init__(
       archive_data_file='data/key_desktop_move_cases.json',
-      cloud_storage_bucket=story.PARTNER_BUCKET)
+      cloud_storage_bucket=story.PARTNER_BUCKET,
+      verify_names=True)
 
     self.AddStory(GmailMouseScrollPage(self))
     self.AddStory(GoogleMapsPage(self))

[cblume, 2017/06/06 20:10:58]

In this case a name is not explicitly specified.
Instead, the url is used if no name is provided.

This differs from what happens in image_decoding_cases.py. Plus this will be the
full url where over there it is just the page name.

This also differs from tough_ad_cases.py where this patch splits the full url to
use the page name as the name.

And it differs again I think in tough_canvas_cases.py, where we seem to trim off
the leading "http://".

Perhaps we want to consolidate onto one method?

In this case (where this comment is) the url doesn't really have a page name. So
maybe we should consolidate onto the full url? And if so, maybe it is okay to
consolidate into using the url as a name if no name is explicitly specified
(like in this .py)?

[ashleymarie1, 2017/06/06 20:35:00]

So what I'm trying to do with all these different methods is keep the generated
names the same as what has been historically generated in telemetry code to
prevent the need for migrations on the dashboard. I agree it would be much nicer
if all of them were consistent but that would require weeks or months of
migrations. For the benchmarks that we know aren't going to be changing / are
stable, we are doing the migrations, but as far as I'm aware, smoothness isn't
on the list of fully stabilized yet.

What we're doing with this specific bug is taking the weird logic generation out
of telemetry and requiring the name be provided to telemetry when the story is
initiated.

[cblume, 2017/06/06 21:07:16]

Ah okay, I follow.
Thank you for the clarification. :D