Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 292663018: [cros login] Cleanup: replace some of Profile usages with BrowserContext. (Closed)

Created:
6 years, 7 months ago by Nikita (slow)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

[cros login] Cleanup: replace some of Profile usages with BrowserContext. BUG=370175 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272845

Patch Set 1 #

Patch Set 2 : add missing include, fix ProxySettingsDialog ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -53 lines) Patch
M chrome/browser/chromeos/login/auth/online_attempt.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.h View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/profile_auth_data.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_web_dialog.h View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_web_dialog.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/ui/proxy_settings_dialog.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/simple_web_view_dialog_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Nikita (slow)
6 years, 7 months ago (2014-05-23 17:19:20 UTC) #1
dzhioev (left Google)
On 2014/05/23 17:19:20, Nikita Kostylev wrote: LGTM
6 years, 7 months ago (2014-05-23 18:11:20 UTC) #2
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-23 18:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/292663018/1
6 years, 7 months ago (2014-05-23 18:13:43 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 22:48:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 23:48:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/30708)
6 years, 7 months ago (2014-05-23 23:48:42 UTC) #7
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-25 22:41:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/292663018/20001
6 years, 7 months ago (2014-05-25 22:41:20 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 01:51:37 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 02:30:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/156883)
6 years, 7 months ago (2014-05-26 02:30:14 UTC) #12
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 7 months ago (2014-05-26 04:14:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/292663018/20001
6 years, 7 months ago (2014-05-26 04:16:09 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:18:08 UTC) #15
Message was sent while issue was closed.
Change committed as 272845

Powered by Google App Engine
This is Rietveld 408576698