Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 292663014: telemetry: use invalidation micro benchmark for repaint (Closed)

Created:
6 years, 7 months ago by ernstm
Modified:
6 years, 6 months ago
Reviewers:
nduca, vmpstr, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

telemetry: use invalidation micro benchmark for repaint Switch repaint benchmark to use invalidation micro benchmark to generate the invalidations. Initial implementation supports three modes: - fixed_size: create invalidations with a random mid point and a fixed size. - layer: invalidate the entire layer (previous behavior of repaint benchmark) - viewport: invalidate the entire viewport - random: invalidate a random rect inside the viewport Depends on https://codereview.chromium.org/298723013/ R=vmpstr@chromium.org,nduca@chromium.org,tonyg@chromium.org BUG=376379 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276018

Patch Set 1 #

Patch Set 2 : Use SendMessage to shut down invalidation benchmark. #

Patch Set 3 : Add fixed_size mode. #

Patch Set 4 : Always enable impl-side painting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M tools/perf/measurements/repaint.py View 1 2 3 2 chunks +52 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/actions/repaint_continuously.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
ernstm
PTAL
6 years, 7 months ago (2014-05-22 22:49:34 UTC) #1
ernstm
On 2014/05/22 22:49:34, ernstm wrote: > PTAL Can we get the review on this CL ...
6 years, 6 months ago (2014-05-30 18:49:34 UTC) #2
ernstm
On 2014/05/30 18:49:34, ernstm wrote: > On 2014/05/22 22:49:34, ernstm wrote: > > PTAL > ...
6 years, 6 months ago (2014-06-04 20:04:26 UTC) #3
tonyg
On 2014/06/04 20:04:26, ernstm wrote: > On 2014/05/30 18:49:34, ernstm wrote: > > On 2014/05/22 ...
6 years, 6 months ago (2014-06-04 20:06:05 UTC) #4
nduca
lgtm
6 years, 6 months ago (2014-06-06 16:01:47 UTC) #5
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 6 months ago (2014-06-06 16:42:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/292663014/40001
6 years, 6 months ago (2014-06-06 16:43:54 UTC) #7
ernstm
The CQ bit was unchecked by ernstm@chromium.org
6 years, 6 months ago (2014-06-06 18:53:23 UTC) #8
ernstm
The CQ bit was checked by ernstm@chromium.org
6 years, 6 months ago (2014-06-09 20:34:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/292663014/60001
6 years, 6 months ago (2014-06-09 20:36:43 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 09:57:34 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 14:31:08 UTC) #12
Message was sent while issue was closed.
Change committed as 276018

Powered by Google App Engine
This is Rietveld 408576698