Issue 292663013: sk_memcpy32 should fall back on libc memcpy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 292663013: sk_memcpy32 should fall back on libc memcpy. (Closed)

Created:
6 years, 7 months ago by mtklein_C

Modified:
6 years, 7 months ago

Reviewers:
henrik.smiding, mtklein

CC:
skia-review_googlegroups.com, qiankun

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

sk_memcpy32 should fall back on libc memcpy. Writing it out ourselves was a ~2x slowdown on ARM. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14886

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -27 lines)			Patch
	M	src/core/SkUtils.cpp	View		2 chunks	+1 line, -27 lines	0 comments	Download

Total messages: 5 (0 generated)

mtklein

Wow, Henrik, great catch. You're completely right: on ARM we saw the benches that call ...

6 years, 7 months ago (2014-05-22 14:09:51 UTC) #1

mtklein

Going to land this guy. Don't want to leave it regressed too long and forget ...

6 years, 7 months ago (2014-05-27 12:40:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/292663013/1

6 years, 7 months ago (2014-05-27 12:40:53 UTC) #4

Message was sent while issue was closed.

Change committed as 14886