Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1481)

Unified Diff: runtime/bin/vmservice/client/deployed/web/index_devtools.html

Issue 292663012: Retaining path in Observatory. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/deployed/web/index_devtools.html
===================================================================
--- runtime/bin/vmservice/client/deployed/web/index_devtools.html (revision 36435)
+++ runtime/bin/vmservice/client/deployed/web/index_devtools.html (working copy)
@@ -7,8 +7,8 @@
<script type="text/javascript" src="https://www.google.com/jsapi"></script>
<script src="packages/browser/interop.js"></script>
- <script src="index_devtools.html_bootstrap.dart.js"></script>
-
+ <script type="application/dart" src="index_devtools.html_bootstrap.dart"></script>
+ <script src="packages/browser/dart.js"></script>
</head>
<body><polymer-element name="curly-block">
<template>
@@ -489,10 +489,10 @@
</style>
<template if="{{ busy }}">
- <span class="busy">[evaluate]</span>
+ <span class="busy">{{ label }}</span>
</template>
<template if="{{ !busy }}">
- <span class="idle"><a on-click="{{ evalNow }}">[evaluate]</a></span>
+ <span class="idle"><a on-click="{{ evalNow }}">{{ label }}</a></span>
</template>
<template if="{{ result != null }}">
= <instance-ref ref="{{ result }}"></instance-ref>
@@ -1514,9 +1514,35 @@
<div class="memberItem">
<div class="memberName">retained size</div>
<div class="memberValue">
- <eval-link callback="{{ retainedSize }}"></eval-link>
+ <eval-link callback="{{ retainedSize }}" label="[calculate]">
+ </eval-link>
</div>
</div>
+ </div>
+ <div class="memberItem">
+ <div class="memberName">retaining path</div>
+ <div class="memberValue">
+ <template if="{{ path == null }}">
+ <eval-link callback="{{ retainingPath }}" label="[find]" expr="10">
+ </eval-link>
+ </template>
+ <template if="{{ path != null }}">
+ <template repeat="{{ element in path['elements'] }}">
+ <div class="memberItem">
+ <div class="memberName">[{{ element['index']}}]</div>
+ <div class="memberValue">
+ <instance-ref ref="{{ element['value'] }}"></instance-ref>
+ </div>
+ </div>
+ </template>
+ <template if="{{ path['length'] > path['elements'].length }}">
+ showing {{ path['elements'].length }} of {{ path['length'] }}
+ <eval-link callback="{{ retainingPath }}" label="[find more]" expr="{{ path['elements'].length * 2 }}">
+ </eval-link>
+ </template>
+ </template>
+ </div>
+ </div>
<template if="{{ instance['type_class'] != null }}">
<div class="memberItem">
<div class="memberName">type class</div>
@@ -1545,7 +1571,7 @@
</div>
</div>
</div>
- </div>
+
<hr>

Powered by Google App Engine
This is Rietveld 408576698