Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292663009: Move chrome/common/metrics/variations to chrome/common/variations. (Closed)

Created:
6 years, 7 months ago by motek.
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang, Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Move chrome/common/metrics/variations to chrome/common/variations. + fixed some lint complaints in renamed files. BUG=375740 TBR=thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -903 lines) Patch
M chrome/browser/chrome_browser_field_trials.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_field_trials_desktop.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_registry_syncer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/metrics/variations/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/common/metrics/variations/experiment_labels.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/common/metrics/variations/experiment_labels.cc View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/common/metrics/variations/experiment_labels_unittest.cc View 1 chunk +0 lines, -193 lines 0 comments Download
D chrome/common/metrics/variations/uniformity_field_trials.h View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/common/metrics/variations/uniformity_field_trials.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/common/metrics/variations/variation_ids.h View 1 chunk +0 lines, -343 lines 0 comments Download
D chrome/common/metrics/variations/variations_util.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/common/metrics/variations/variations_util.cc View 1 chunk +0 lines, -19 lines 0 comments Download
A + chrome/common/variations/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/common/variations/experiment_labels.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/variations/experiment_labels.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + chrome/common/variations/experiment_labels_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/variations/uniformity_field_trials.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/variations/uniformity_field_trials.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/common/variations/variation_ids.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/variations/variations_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/common/variations/variations_util.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
motek.
Here is another mechanolist for your (re)viewing pleasure.
6 years, 7 months ago (2014-05-21 15:54:44 UTC) #1
Ilya Sherman
LGTM. Thanks!
6 years, 7 months ago (2014-05-21 15:59:48 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 7 months ago (2014-05-21 15:59:53 UTC) #3
Ilya Sherman
TBR Lei for a mechanical refactoring change within //chrome.
6 years, 7 months ago (2014-05-21 16:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/motek@chromium.org/292663009/1
6 years, 7 months ago (2014-05-21 19:59:08 UTC) #5
Lei Zhang
lgtm
6 years, 7 months ago (2014-05-21 20:40:05 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 03:58:44 UTC) #7
Message was sent while issue was closed. 
Change committed as 272082

Powered by Google App Engine
This is Rietveld 408576698