Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 292663008: Make shouldTransformOnTextPainting compilation unit local (Closed)

Created:
6 years, 7 months ago by davve
Modified:
6 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@turn-assert_unused-into-plain
Visibility:
Public.

Description

Make shouldTransformOnTextPainting compilation unit local No need to have this as a public function of the class. It's only used in one place, local to the class implementation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174633

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.cpp View 2 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davve
One less global symbol for the linker to handle. I was a little quick to ...
6 years, 7 months ago (2014-05-22 07:08:09 UTC) #1
pdr.
On 2014/05/22 07:08:09, David Vest wrote: > One less global symbol for the linker to ...
6 years, 7 months ago (2014-05-22 21:32:16 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 7 months ago (2014-05-22 21:32:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/292663008/1
6 years, 7 months ago (2014-05-22 21:33:32 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 01:55:35 UTC) #5
Message was sent while issue was closed.
Change committed as 174633

Powered by Google App Engine
This is Rietveld 408576698