Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/dev_compiler/test/codegen_expected/equality_test.js

Issue 2926613003: Generate better code for '=='. (Closed)
Patch Set: Identical, dtest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/dev_compiler/lib/src/compiler/js_typerep.dart ('K') | « pkg/dev_compiler/test/codegen_expected/async_helper.js ('k') | pkg/dev_compiler/test/codegen_expected/identity_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/test/codegen_expected/equality_test.js
diff --git a/pkg/dev_compiler/test/codegen_expected/equality_test.js b/pkg/dev_compiler/test/codegen_expected/equality_test.js
index a8c227291ecac5cb37a2390c0162ad845f8b3bdd..2efed1dea0fbb85e0a7066409864e20991cf15ff 100644
--- a/pkg/dev_compiler/test/codegen_expected/equality_test.js
+++ b/pkg/dev_compiler/test/codegen_expected/equality_test.js
@@ -67,13 +67,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = equality_test.hideNull(equality_test.Music)(equality_test.Music.western);
let o1 = equality_test.hideNull(core.Object)(equality_test.Music.country);
let o2 = equality_test.hideNull(core.Object)(equality_test.Music.western);
- minitest.expect(dart.equals(e1, e1), true);
+ minitest.expect(e1 == e1, true);
minitest.expect(dart.equals(e1, d1), true);
minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(dart.equals(e1, e2), false);
+ minitest.expect(e1 == e2, false);
minitest.expect(dart.equals(e1, o2), false);
minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(dart.equals(e1, e2), false);
+ minitest.expect(e1 == e2, false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -94,13 +94,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = equality_test.Music.western;
let o1 = equality_test.Music.country;
let o2 = equality_test.Music.western;
- minitest.expect(dart.equals(e1, e1), true);
- minitest.expect(dart.equals(e1, d1), true);
- minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(dart.equals(e1, e2), false);
- minitest.expect(dart.equals(e1, o2), false);
- minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(dart.equals(e1, e2), false);
+ minitest.expect(e1 === e1, true);
+ minitest.expect(e1 === d1, true);
+ minitest.expect(e1 === o1, true);
+ minitest.expect(e1 === e2, false);
+ minitest.expect(e1 === o2, false);
+ minitest.expect(e1 === d2, false);
+ minitest.expect(e1 === e2, false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -126,8 +126,8 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
minitest.expect(dart.equals(e1, s2), false);
minitest.expect(dart.equals(e1, i1), false);
minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
+ minitest.expect(e1 == l1, false);
+ minitest.expect(e1 == b1, false);
minitest.expect(dart.equals(s1, e1), false);
minitest.expect(dart.equals(s2, e1), false);
minitest.expect(dart.equals(i1, e1), false);
@@ -143,18 +143,18 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
}, VoidToNull()));
minitest.test('Equal enum/other (dynamic, nullable)', dart.fn(() => {
let e1 = equality_test.hideNull(equality_test.Music)(equality_test.Music.country);
@@ -199,30 +199,30 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
minitest.expect(dart.equals(d1, s1), false);
minitest.expect(dart.equals(d1, s2), false);
minitest.expect(dart.equals(d1, i1), false);
minitest.expect(dart.equals(d1, i2), false);
minitest.expect(dart.equals(d1, l1), false);
minitest.expect(dart.equals(d1, b1), false);
- minitest.expect(dart.equals(s1, d1), false);
- minitest.expect(dart.equals(s2, d1), false);
- minitest.expect(dart.equals(i1, d1), false);
- minitest.expect(dart.equals(i2, d1), false);
- minitest.expect(dart.equals(l1, d1), false);
- minitest.expect(dart.equals(b1, d1), false);
+ minitest.expect(s1 === d1, false);
+ minitest.expect(s2 === d1, false);
+ minitest.expect(i1 === d1, false);
+ minitest.expect(i2 === d1, false);
+ minitest.expect(l1[dartx['==']](d1), false);
+ minitest.expect(b1['=='](d1), false);
}, VoidToNull()));
}, VoidToNull()));
minitest.group('String equality', dart.fn(() => {
@@ -260,13 +260,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = "Band";
let o1 = "The";
let o2 = "Band";
- minitest.expect(e1 == e1, true);
- minitest.expect(dart.equals(e1, d1), true);
- minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(e1 == e2, false);
- minitest.expect(dart.equals(e1, o2), false);
- minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(e1 == e2, false);
+ minitest.expect(e1 === e1, true);
+ minitest.expect(e1 === d1, true);
+ minitest.expect(e1 === o1, true);
+ minitest.expect(e1 === e2, false);
+ minitest.expect(e1 === o2, false);
+ minitest.expect(e1 === d2, false);
+ minitest.expect(e1 === e2, false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -309,18 +309,18 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(e1 == s1, false);
- minitest.expect(e1 == s2, false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(s1 == e1, false);
- minitest.expect(s2 == e1, false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
}, VoidToNull()));
minitest.test('Equal string/other (dynamic, nullable)', dart.fn(() => {
let e1 = equality_test.hideNull(core.String)("The");
@@ -365,30 +365,30 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(e1 == s1, false);
- minitest.expect(e1 == s2, false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(s1 == e1, false);
- minitest.expect(s2 == e1, false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
minitest.expect(dart.equals(d1, s1), false);
minitest.expect(dart.equals(d1, s2), false);
minitest.expect(dart.equals(d1, i1), false);
minitest.expect(dart.equals(d1, i2), false);
minitest.expect(dart.equals(d1, l1), false);
minitest.expect(dart.equals(d1, b1), false);
- minitest.expect(dart.equals(s1, d1), false);
- minitest.expect(dart.equals(s2, d1), false);
- minitest.expect(dart.equals(i1, d1), false);
- minitest.expect(dart.equals(i2, d1), false);
- minitest.expect(dart.equals(l1, d1), false);
- minitest.expect(dart.equals(b1, d1), false);
+ minitest.expect(s1 === d1, false);
+ minitest.expect(s2 === d1, false);
+ minitest.expect(i1 === d1, false);
+ minitest.expect(i2 === d1, false);
+ minitest.expect(l1[dartx['==']](d1), false);
+ minitest.expect(b1['=='](d1), false);
}, VoidToNull()));
}, VoidToNull()));
minitest.group('Boolean equality', dart.fn(() => {
@@ -426,13 +426,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = false;
let o1 = true;
let o2 = false;
- minitest.expect(e1 == e1, true);
- minitest.expect(dart.equals(e1, d1), true);
- minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(e1 == e2, false);
- minitest.expect(dart.equals(e1, o2), false);
- minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(e1 == e2, false);
+ minitest.expect(e1 === e1, true);
+ minitest.expect(e1 === d1, true);
+ minitest.expect(e1 === o1, true);
+ minitest.expect(e1 === e2, false);
+ minitest.expect(e1 === o2, false);
+ minitest.expect(e1 === d2, false);
+ minitest.expect(e1 === e2, false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -475,18 +475,18 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
}, VoidToNull()));
minitest.test('Equal bool/other (dynamic, nullable)', dart.fn(() => {
let e1 = equality_test.hideNull(core.bool)(true);
@@ -531,30 +531,30 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
minitest.expect(dart.equals(d1, s1), false);
minitest.expect(dart.equals(d1, s2), false);
minitest.expect(dart.equals(d1, i1), false);
minitest.expect(dart.equals(d1, i2), false);
minitest.expect(dart.equals(d1, l1), false);
minitest.expect(dart.equals(d1, b1), false);
- minitest.expect(dart.equals(s1, d1), false);
- minitest.expect(dart.equals(s2, d1), false);
- minitest.expect(dart.equals(i1, d1), false);
- minitest.expect(dart.equals(i2, d1), false);
- minitest.expect(dart.equals(l1, d1), false);
- minitest.expect(dart.equals(b1, d1), false);
+ minitest.expect(s1 === d1, false);
+ minitest.expect(s2 === d1, false);
+ minitest.expect(i1 === d1, false);
+ minitest.expect(i2 === d1, false);
+ minitest.expect(l1[dartx['==']](d1), false);
+ minitest.expect(b1['=='](d1), false);
}, VoidToNull()));
}, VoidToNull()));
minitest.group('String equality', dart.fn(() => {
@@ -592,13 +592,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = "Band";
let o1 = "The";
let o2 = "Band";
- minitest.expect(e1 == e1, true);
- minitest.expect(dart.equals(e1, d1), true);
- minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(e1 == e2, false);
- minitest.expect(dart.equals(e1, o2), false);
- minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(e1 == e2, false);
+ minitest.expect(e1 === e1, true);
+ minitest.expect(e1 === d1, true);
+ minitest.expect(e1 === o1, true);
+ minitest.expect(e1 === e2, false);
+ minitest.expect(e1 === o2, false);
+ minitest.expect(e1 === d2, false);
+ minitest.expect(e1 === e2, false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -641,18 +641,18 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(e1 == s1, false);
- minitest.expect(e1 == s2, false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(s1 == e1, false);
- minitest.expect(s2 == e1, false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
}, VoidToNull()));
minitest.test('Equal string/other (dynamic, nullable)', dart.fn(() => {
let e1 = equality_test.hideNull(core.String)("The");
@@ -697,30 +697,30 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(e1 == s1, false);
- minitest.expect(e1 == s2, false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(s1 == e1, false);
- minitest.expect(s2 == e1, false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
minitest.expect(dart.equals(d1, s1), false);
minitest.expect(dart.equals(d1, s2), false);
minitest.expect(dart.equals(d1, i1), false);
minitest.expect(dart.equals(d1, i2), false);
minitest.expect(dart.equals(d1, l1), false);
minitest.expect(dart.equals(d1, b1), false);
- minitest.expect(dart.equals(s1, d1), false);
- minitest.expect(dart.equals(s2, d1), false);
- minitest.expect(dart.equals(i1, d1), false);
- minitest.expect(dart.equals(i2, d1), false);
- minitest.expect(dart.equals(l1, d1), false);
- minitest.expect(dart.equals(b1, d1), false);
+ minitest.expect(s1 === d1, false);
+ minitest.expect(s2 === d1, false);
+ minitest.expect(i1 === d1, false);
+ minitest.expect(i2 === d1, false);
+ minitest.expect(l1[dartx['==']](d1), false);
+ minitest.expect(b1['=='](d1), false);
}, VoidToNull()));
}, VoidToNull()));
minitest.group('Number equality', dart.fn(() => {
@@ -758,13 +758,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = 12;
let o1 = 11;
let o2 = 12;
- minitest.expect(e1 == e1, true);
- minitest.expect(dart.equals(e1, d1), true);
- minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(e1 == e2, false);
- minitest.expect(dart.equals(e1, o2), false);
- minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(e1 == e2, false);
+ minitest.expect(e1 === e1, true);
+ minitest.expect(e1 === d1, true);
+ minitest.expect(e1 === o1, true);
+ minitest.expect(e1 === e2, false);
+ minitest.expect(e1 === o2, false);
+ minitest.expect(e1 === d2, false);
+ minitest.expect(e1 === e2, false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -807,18 +807,18 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(e1 == i1, false);
- minitest.expect(e1 == i2, false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(i1 == e1, false);
- minitest.expect(i2 == e1, false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
}, VoidToNull()));
minitest.test('Equal int/other (dynamic, nullable)', dart.fn(() => {
let e1 = equality_test.hideNull(core.int)(11);
@@ -863,30 +863,30 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(e1 == i1, false);
- minitest.expect(e1 == i2, false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(i1 == e1, false);
- minitest.expect(i2 == e1, false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1 === s1, false);
+ minitest.expect(e1 === s2, false);
+ minitest.expect(e1 === i1, false);
+ minitest.expect(e1 === i2, false);
+ minitest.expect(e1 === l1, false);
+ minitest.expect(e1 === b1, false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
minitest.expect(dart.equals(d1, s1), false);
minitest.expect(dart.equals(d1, s2), false);
minitest.expect(dart.equals(d1, i1), false);
minitest.expect(dart.equals(d1, i2), false);
minitest.expect(dart.equals(d1, l1), false);
minitest.expect(dart.equals(d1, b1), false);
- minitest.expect(dart.equals(s1, d1), false);
- minitest.expect(dart.equals(s2, d1), false);
- minitest.expect(dart.equals(i1, d1), false);
- minitest.expect(dart.equals(i2, d1), false);
- minitest.expect(dart.equals(l1, d1), false);
- minitest.expect(dart.equals(b1, d1), false);
+ minitest.expect(s1 === d1, false);
+ minitest.expect(s2 === d1, false);
+ minitest.expect(i1 === d1, false);
+ minitest.expect(i2 === d1, false);
+ minitest.expect(l1[dartx['==']](d1), false);
+ minitest.expect(b1['=='](d1), false);
}, VoidToNull()));
}, VoidToNull()));
minitest.group('Object equality', dart.fn(() => {
@@ -924,13 +924,13 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let d2 = new equality_test._Elwood.new();
let o1 = e1;
let o2 = new equality_test._Elwood.new();
- minitest.expect(dart.equals(e1, e1), true);
- minitest.expect(dart.equals(e1, d1), true);
- minitest.expect(dart.equals(e1, o1), true);
- minitest.expect(dart.equals(e1, e2), false);
- minitest.expect(dart.equals(e1, o2), false);
- minitest.expect(dart.equals(e1, d2), false);
- minitest.expect(dart.equals(e1, e2), false);
+ minitest.expect(e1['=='](e1), true);
+ minitest.expect(e1['=='](d1), true);
+ minitest.expect(e1['=='](o1), true);
+ minitest.expect(e1['=='](e2), false);
+ minitest.expect(e1['=='](o2), false);
+ minitest.expect(e1['=='](d2), false);
+ minitest.expect(e1['=='](e2), false);
minitest.expect(dart.equals(d1, e1), true);
minitest.expect(dart.equals(d1, d1), true);
minitest.expect(dart.equals(d1, o1), true);
@@ -973,18 +973,18 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1['=='](s1), false);
+ minitest.expect(e1['=='](s2), false);
+ minitest.expect(e1['=='](i1), false);
+ minitest.expect(e1['=='](i2), false);
+ minitest.expect(e1['=='](l1), false);
+ minitest.expect(e1['=='](b1), false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
}, VoidToNull()));
minitest.test('Equal object/other (dynamic, nullable)', dart.fn(() => {
let e1 = equality_test.hideNull(equality_test._Jake)(new equality_test._Jake.new());
@@ -1029,30 +1029,30 @@ define(['dart_sdk', 'expect'], function(dart_sdk, expect) {
let i2 = 0;
let l1 = core.List.new(3);
let b1 = new equality_test._Norman.new();
- minitest.expect(dart.equals(e1, s1), false);
- minitest.expect(dart.equals(e1, s2), false);
- minitest.expect(dart.equals(e1, i1), false);
- minitest.expect(dart.equals(e1, i2), false);
- minitest.expect(dart.equals(e1, l1), false);
- minitest.expect(dart.equals(e1, b1), false);
- minitest.expect(dart.equals(s1, e1), false);
- minitest.expect(dart.equals(s2, e1), false);
- minitest.expect(dart.equals(i1, e1), false);
- minitest.expect(dart.equals(i2, e1), false);
- minitest.expect(dart.equals(l1, e1), false);
- minitest.expect(dart.equals(b1, e1), false);
+ minitest.expect(e1['=='](s1), false);
+ minitest.expect(e1['=='](s2), false);
+ minitest.expect(e1['=='](i1), false);
+ minitest.expect(e1['=='](i2), false);
+ minitest.expect(e1['=='](l1), false);
+ minitest.expect(e1['=='](b1), false);
+ minitest.expect(s1 === e1, false);
+ minitest.expect(s2 === e1, false);
+ minitest.expect(i1 === e1, false);
+ minitest.expect(i2 === e1, false);
+ minitest.expect(l1[dartx['==']](e1), false);
+ minitest.expect(b1['=='](e1), false);
minitest.expect(dart.equals(d1, s1), false);
minitest.expect(dart.equals(d1, s2), false);
minitest.expect(dart.equals(d1, i1), false);
minitest.expect(dart.equals(d1, i2), false);
minitest.expect(dart.equals(d1, l1), false);
minitest.expect(dart.equals(d1, b1), false);
- minitest.expect(dart.equals(s1, d1), false);
- minitest.expect(dart.equals(s2, d1), false);
- minitest.expect(dart.equals(i1, d1), false);
- minitest.expect(dart.equals(i2, d1), false);
- minitest.expect(dart.equals(l1, d1), false);
- minitest.expect(dart.equals(b1, d1), false);
+ minitest.expect(s1 === d1, false);
+ minitest.expect(s2 === d1, false);
+ minitest.expect(i1 === d1, false);
+ minitest.expect(i2 === d1, false);
+ minitest.expect(l1[dartx['==']](d1), false);
+ minitest.expect(b1['=='](d1), false);
}, VoidToNull()));
}, VoidToNull()));
minitest.group('Null/undefined equality', dart.fn(() => {
« pkg/dev_compiler/lib/src/compiler/js_typerep.dart ('K') | « pkg/dev_compiler/test/codegen_expected/async_helper.js ('k') | pkg/dev_compiler/test/codegen_expected/identity_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698