V4L2SVDA/VAAPIVDA: use visible size from decoder and pass to client

media/gpu/h264_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <limits>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback_helpers.h"
@@ skipping 1075 matching lines @@
     DVLOG(1) << "frame_mbs_only_flag != 1 not supported";
     return false;
   }
 
   gfx::Size new_pic_size = sps->GetCodedSize().value_or(gfx::Size());
   if (new_pic_size.IsEmpty()) {
     DVLOG(1) << "Invalid picture size";
     return false;
   }
 
+  gfx::Rect new_visible_rect = sps->GetVisibleRect().value_or(gfx::Rect());

[Pawel Osciak, 2017/06/16 07:14:00]

Would it make sense to move this to l.1133 and also check against pic_size?

[johnylin1, 2017/06/16 08:15:10]

Moved to l.1133. sps->GetVisibleRect() already checked visible_size against
pic_size, so we don't need to check again.
https://cs.chromium.org/chromium/src/media/filters/h264_parser.cc?q=h264_pars...

+  if (visible_rect_ != new_visible_rect) {
+    DVLOG(2) << "New visible rect: " << new_visible_rect.ToString();
+    visible_rect_ = new_visible_rect;
+  }
+
   int width_mb = new_pic_size.width() / 16;
   int height_mb = new_pic_size.height() / 16;
 
   // Verify that the values are not too large before multiplying.
   if (std::numeric_limits<int>::max() / width_mb < height_mb) {
     DVLOG(1) << "Picture size is too big: " << new_pic_size.ToString();
     return false;
   }
 
   int level = sps->level_idc;
@@ skipping 238 matching lines @@
             SET_ERROR_AND_RETURN();
         }
 
         if (!curr_pic_) {
           // New picture/finished previous one, try to start a new one
           // or tell the client we need more surfaces.
           curr_pic_ = accelerator_->CreateH264Picture();
           if (!curr_pic_)
             return kRanOutOfSurfaces;
 
+          curr_pic_->visible_rect = visible_rect_;

[Pawel Osciak, 2017/06/16 07:14:00]

Could we perhaps move this to InitCurrPicture()?

           if (!StartNewFrame(curr_slice_hdr_.get()))
             SET_ERROR_AND_RETURN();
         }
 
         if (!ProcessCurrentSlice())
           SET_ERROR_AND_RETURN();
 
         curr_slice_hdr_.reset();
         break;
       }
@@ skipping 63 matching lines @@
 
 gfx::Size H264Decoder::GetPicSize() const {
   return pic_size_;
 }
 
 size_t H264Decoder::GetRequiredNumOfPictures() const {
   return dpb_.max_num_pics() + kPicsInPipeline;
 }
 
 }  // namespace media