ui/webui/resources/js/i18n_behavior.js - Issue 2926573003: [MD settings] allow unicode nbsp in i18n behavior strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/i18n_behavior.js

Issue 2926573003: [MD settings] allow unicode nbsp in i18n behavior strings (Closed)

Patch Set: reduced comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/js/i18n_behavior.js

diff --git a/ui/webui/resources/js/i18n_behavior.js b/ui/webui/resources/js/i18n_behavior.js

index 95722a1df4ae6be7ae89aeb445fcf76dfb0b510b..89e1d8aa4e5a16757b3ab8ee2620b997a5f7b435 100644

--- a/ui/webui/resources/js/i18n_behavior.js

+++ b/ui/webui/resources/js/i18n_behavior.js

@@ -46,7 +46,10 @@ var I18nBehavior = {

i18n: function(id, var_args) {

var rawString = this.i18nRaw_.apply(this, arguments);

- return parseHtmlSubset('<b>' + rawString + '</b>').firstChild.innerHTML;

+ var htmlStr =

+ parseHtmlSubset('<b>' + rawString + '</b>').firstChild.innerHTML;

+ // TODO(dschuyler): use textContent rather than innerHTML; remove replace().

+ return htmlStr.replace(' ', '\u00a0');

/**

« no previous file with comments | « chrome/test/data/webui/i18n_behavior_test.html ('k') | no next file » | no next file with comments »