Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11528)

Unified Diff: chrome/browser/ui/views/chrome_cleaner_dialog_win.cc

Issue 2926533002: Remove references to ui/views/layout/layout_constants.h (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/sad_tab_view.cc » ('j') | chrome/browser/ui/views/sad_tab_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
diff --git a/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc b/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
index 81b1596c30602c16bd35d56782daae6d8df01bfb..901a970329bd186e2cea096f71312ab7b83d814a 100644
--- a/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
+++ b/chrome/browser/ui/views/chrome_cleaner_dialog_win.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/views/harmony/chrome_layout_provider.h"
#include "components/constrained_window/constrained_window_views.h"
#include "ui/base/ui_base_types.h"
#include "ui/events/event.h"
@@ -17,7 +18,6 @@
#include "ui/views/controls/button/md_text_button.h"
#include "ui/views/controls/label.h"
#include "ui/views/layout/box_layout.h"
-#include "ui/views/layout/layout_constants.h"
#include "ui/views/widget/widget.h"
namespace chrome {
@@ -43,10 +43,12 @@ ChromeCleanerDialog::ChromeCleanerDialog(
: browser_(nullptr), controller_(controller) {
DCHECK(controller_);
+ gfx::Insets dialog_insets = ChromeLayoutProvider::Get()->GetInsetsMetric(
+ views::INSETS_DIALOG_CONTENTS);
Peter Kasting 2017/06/06 03:34:33 For this file, wait on https://chromium-review.goo
ananta 2017/06/06 03:44:56 Sure reverted this change
SetLayoutManager(new views::BoxLayout(
/*orientation=*/views::BoxLayout::kVertical,
- /*inside_border_horizontal_spacing=*/views::kButtonHEdgeMarginNew,
- /*inside_border_vertical_spacing=*/views::kPanelVertMargin,
+ /*inside_border_horizontal_spacing=*/dialog_insets.left(),
+ /*inside_border_vertical_spacing=*/dialog_insets.top(),
/*between_child_spacing=*/0));
views::Label* label = new views::Label(controller_->GetMainText());
label->SetMultiLine(true);
« no previous file with comments | « no previous file | chrome/browser/ui/views/sad_tab_view.cc » ('j') | chrome/browser/ui/views/sad_tab_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698