Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292653003: Move AddBuildTypeOption to adb_install_apk.py and remove test_options_parser.py (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 7 months ago
Reviewers:
bulach, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move AddBuildTypeOption to adb_install_apk.py and remove test_options_parser.py BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271820

Patch Set 1 #

Patch Set 2 : style fix #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -70 lines) Patch
M build/android/adb_install_apk.py View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
D build/android/pylib/utils/test_options_parser.py View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mlamouri (slow - plz ping)
6 years, 7 months ago (2014-05-17 15:37:08 UTC) #1
bulach
lgtm, thanks, nice find! please wait for john, he owns all of these nowadays... tiny ...
6 years, 7 months ago (2014-05-19 10:19:22 UTC) #2
mlamouri (slow - plz ping)
https://codereview.chromium.org/292653003/diff/20001/build/android/adb_install_apk.py File build/android/adb_install_apk.py (right): https://codereview.chromium.org/292653003/diff/20001/build/android/adb_install_apk.py#newcode22 build/android/adb_install_apk.py:22: default_build_type = 'Debug' On 2014/05/19 10:19:22, bulach wrote: > ...
6 years, 7 months ago (2014-05-19 13:15:38 UTC) #3
jbudorick
lgtm
6 years, 7 months ago (2014-05-19 14:34:43 UTC) #4
mlamouri (slow - plz ping)
On 2014/05/19 14:34:43, jbudorick wrote: > lgtm Thanks! :) I will land this as soon ...
6 years, 7 months ago (2014-05-20 13:10:06 UTC) #5
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 7 months ago (2014-05-20 19:52:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/292653003/40001
6 years, 7 months ago (2014-05-20 19:54:21 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 02:27:42 UTC) #8
Message was sent while issue was closed. 
Change committed as 271820

Powered by Google App Engine
This is Rietveld 408576698