Mac Archive Type Sniffing

chrome/browser/safe_browsing/download_protection_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
@@ skipping 15 matching lines @@
 #include "base/sha1.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/safe_browsing/download_feedback_service.h"
 #include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"
 #include "chrome/browser/safe_browsing/local_database_manager.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
+#include "chrome/common/chrome_paths.h"
 #include "chrome/common/safe_browsing/binary_feature_extractor.h"
 #include "chrome/common/safe_browsing/file_type_policies_test_util.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/history/core/browser/history_service.h"
 #include "components/prefs/pref_service.h"
 #include "components/safe_browsing/common/safe_browsing_prefs.h"
 #include "components/safe_browsing/common/safebrowsing_switches.h"
 #include "components/safe_browsing/csd.pb.h"
 #include "components/safe_browsing_db/database_manager.h"
 #include "components/safe_browsing_db/test_database_manager.h"
@@ skipping 302 matching lines @@
       if (archived_binary.file_basename() == file_basename)
         return &archived_binary;
     }
     return nullptr;
   }
 
   // Flushes any pending tasks in the message loops of all threads.
   void FlushThreadMessageLoops() {
     BrowserThread::GetBlockingPool()->FlushForTesting();
     FlushMessageLoop(BrowserThread::IO);
+    FlushMessageLoop(BrowserThread::FILE);
     RunLoop().RunUntilIdle();
   }
 
   // Proxy for private method.
   static void GetCertificateWhitelistStrings(
       const net::X509Certificate& certificate,
       const net::X509Certificate& issuer,
       std::vector<std::string>* whitelist_strings) {
     DownloadProtectionService::GetCertificateWhitelistStrings(
         certificate, issuer, whitelist_strings);
@@ skipping 1068 matching lines @@
 TEST_F(DownloadProtectionServiceTest,
        CheckClientDownloadReportCorruptZip) {
   CheckClientDownloadReportCorruptArchive(ZIP);
 }
 
 #if defined(OS_MACOSX)
 TEST_F(DownloadProtectionServiceTest,
        CheckClientDownloadReportCorruptDmg) {
   CheckClientDownloadReportCorruptArchive(DMG);
 }
-#endif
+
+// Test that downloaded files with no disk image extension that have a 'koly'
+// trailer are treated as disk images and processed accordingly.
+TEST_F(DownloadProtectionServiceTest,
+       CheckClientDownloadReportDmgWithoutExtension) {
+  net::FakeURLFetcherFactory factory(NULL);
+  PrepareResponse(&factory, ClientDownloadResponse::SAFE, net::HTTP_OK,
+                  net::URLRequestStatus::SUCCESS);
+
+  base::FilePath test_data;
+  EXPECT_TRUE(PathService::Get(chrome::DIR_GEN_TEST_DATA, &test_data));
+  test_data = test_data.AppendASCII("chrome")
+                  .AppendASCII("safe_browsing_dmg")
+                  .AppendASCII("mach_o_in_dmg.txt");
+
+  NiceMockDownloadItem item;
+  PrepareBasicDownloadItemWithFullPaths(
+      &item, {"http://www.evil.com/a.dmg"},                     // url_chain
+      "http://www.google.com/",                                 // referrer
+      test_data,                                                // tmp_path
+      temp_dir_.GetPath().Append(FILE_PATH_LITERAL("a.dmg")));  // final_path
+
+  RunLoop run_loop;
+  download_service_->CheckClientDownload(
+      &item, base::Bind(&DownloadProtectionServiceTest::CheckDoneCallback,
+                        base::Unretained(this), run_loop.QuitClosure()));
+  run_loop.Run();
+
+  ASSERT_TRUE(HasClientDownloadRequest());
+  EXPECT_TRUE(GetClientDownloadRequest()->archive_valid());
+  ClearClientDownloadRequest();
+
+  Mock::VerifyAndClearExpectations(sb_service_.get());
+  Mock::VerifyAndClearExpectations(binary_feature_extractor_.get());
+}
+
+// Demonstrate that a .dmg file whose a) extension has been changed to .txt and
+// b) 'koly' signature has been removed is not processed as a disk image.
+TEST_F(DownloadProtectionServiceTest, CheckClientDownloadReportDmgWithoutKoly) {
+  net::FakeURLFetcherFactory factory(NULL);
+  PrepareResponse(&factory, ClientDownloadResponse::SAFE, net::HTTP_OK,
+                  net::URLRequestStatus::SUCCESS);
+
+  base::FilePath test_data;
+  EXPECT_TRUE(PathService::Get(chrome::DIR_GEN_TEST_DATA, &test_data));
+  test_data = test_data.AppendASCII("chrome")
+                  .AppendASCII("safe_browsing_dmg")
+                  .AppendASCII("mach_o_in_dmg_no_koly_signature.txt");
+
+  NiceMockDownloadItem item;
+  PrepareBasicDownloadItemWithFullPaths(
+      &item, {"http://www.evil.com/a.dmg"},                     // url_chain
+      "http://www.google.com/",                                 // referrer
+      test_data,                                                // tmp_path
+      temp_dir_.GetPath().Append(FILE_PATH_LITERAL("a.dmg")));  // final_path
+
+  RunLoop run_loop;
+  download_service_->CheckClientDownload(
+      &item, base::Bind(&DownloadProtectionServiceTest::CheckDoneCallback,
+                        base::Unretained(this), run_loop.QuitClosure()));
+  run_loop.Run();
+
+  ASSERT_TRUE(HasClientDownloadRequest());
+  EXPECT_FALSE(GetClientDownloadRequest()->archive_valid());
+  ClearClientDownloadRequest();
+
+  Mock::VerifyAndClearExpectations(sb_service_.get());
+  Mock::VerifyAndClearExpectations(binary_feature_extractor_.get());
+}
+
+#endif  // OS_MACOSX
 
 TEST_F(DownloadProtectionServiceTest, CheckClientDownloadValidateRequest) {
   net::TestURLFetcherFactory factory;
 
+#if defined(OS_MACOSX)
+  std::string download_file_path("ftp://www.google.com/bla.dmg");
+#else
+  std::string download_file_path("ftp://www.google.com/bla.exe");
+#endif  //  OS_MACOSX
+
   NiceMockDownloadItem item;
+#if defined(OS_MACOSX)
   PrepareBasicDownloadItem(
-    &item,
-    {"http://www.google.com/",
-     "http://www.google.com/bla.exe"},  // url_chain
-    "http://www.google.com/",           // referrer
-    FILE_PATH_LITERAL("bla.tmp"),       // tmp_path
-    FILE_PATH_LITERAL("bla.exe"));      // final_path
+      &item, {"http://www.google.com/", download_file_path},  // url_chain
+      "http://www.google.com/",                               // referrer
+      FILE_PATH_LITERAL("bla.tmp"),                           // tmp_path
+      FILE_PATH_LITERAL("bla.dmg"));                          // final_path
+#else
+  PrepareBasicDownloadItem(
+      &item, {"http://www.google.com/", download_file_path},  // url_chain
+      "http://www.google.com/",                               // referrer
+      FILE_PATH_LITERAL("bla.tmp"),                           // tmp_path
+      FILE_PATH_LITERAL("bla.exe"));                          // final_path
+#endif  // OS_MACOSX
 
   std::string remote_address = "10.11.12.13";
   EXPECT_CALL(item, GetRemoteAddress()).WillRepeatedly(Return(remote_address));
 
   EXPECT_CALL(*sb_service_->mock_database_manager(),
               MatchDownloadWhitelistUrl(_))
       .WillRepeatedly(Return(false));
+#if !defined(OS_MACOSX)
   EXPECT_CALL(*binary_feature_extractor_.get(), CheckSignature(tmp_path_, _))
       .WillOnce(SetCertificateContents("dummy cert data"));
   EXPECT_CALL(
       *binary_feature_extractor_.get(),
       ExtractImageFeatures(tmp_path_, BinaryFeatureExtractor::kDefaultOptions,
                            _, _))
       .WillOnce(SetDosHeaderContents("dummy dos header"));
+#endif  // OS_MACOSX
   RunLoop run_loop;
   download_service_->CheckClientDownload(
       &item, base::Bind(&DownloadProtectionServiceTest::CheckDoneCallback,
                         base::Unretained(this), run_loop.QuitClosure()));
 
   // Run the message loop(s) until SendRequest is called.
   FlushThreadMessageLoops();
   EXPECT_TRUE(HasClientDownloadRequest());
   ClearClientDownloadRequest();
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   ASSERT_TRUE(fetcher);
   ClientDownloadRequest request;
   EXPECT_TRUE(request.ParseFromString(fetcher->upload_data()));
-  EXPECT_EQ("http://www.google.com/bla.exe", request.url());
+  EXPECT_EQ(download_file_path, request.url());
   EXPECT_EQ(hash_, request.digests().sha256());
   EXPECT_EQ(item.GetReceivedBytes(), request.length());
   EXPECT_EQ(item.HasUserGesture(), request.user_initiated());
   EXPECT_TRUE(RequestContainsServerIp(request, remote_address));
   EXPECT_EQ(2, request.resources_size());
   EXPECT_TRUE(RequestContainsResource(request,
                                       ClientDownloadRequest::DOWNLOAD_REDIRECT,
                                       "http://www.google.com/", ""));
   EXPECT_TRUE(RequestContainsResource(request,
                                       ClientDownloadRequest::DOWNLOAD_URL,
-                                      "http://www.google.com/bla.exe",
-                                      referrer_.spec()));
+                                      download_file_path, referrer_.spec()));
   EXPECT_TRUE(request.has_signature());
+#if !defined(OS_MACOSX)
   ASSERT_EQ(1, request.signature().certificate_chain_size());
   const ClientDownloadRequest_CertificateChain& chain =
       request.signature().certificate_chain(0);
   ASSERT_EQ(1, chain.element_size());
   EXPECT_EQ("dummy cert data", chain.element(0).certificate());
   EXPECT_TRUE(request.has_image_headers());
   const ClientDownloadRequest_ImageHeaders& headers =
       request.image_headers();
   EXPECT_TRUE(headers.has_pe_headers());
   EXPECT_TRUE(headers.pe_headers().has_dos_header());
   EXPECT_EQ("dummy dos header", headers.pe_headers().dos_header());
+#endif  // OS_MACOSX
 
   // Simulate the request finishing.
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE,
       base::BindOnce(&DownloadProtectionServiceTest::SendURLFetchComplete,
                      base::Unretained(this), fetcher));
   run_loop.Run();
 }
 
 // Similar to above, but with an unsigned binary.
 TEST_F(DownloadProtectionServiceTest,
        CheckClientDownloadValidateRequestNoSignature) {
   net::TestURLFetcherFactory factory;
 
+#if defined(OS_MACOSX)
+  std::string download_file_path("ftp://www.google.com/bla.dmg");
+#else
+  std::string download_file_path("ftp://www.google.com/bla.exe");
+#endif  // OS_MACOSX
+
   NiceMockDownloadItem item;
+#if defined(OS_MACOSX)
   PrepareBasicDownloadItem(
-    &item,
-    {"http://www.google.com/",
-     "ftp://www.google.com/bla.exe"},  // url_chain
-    "http://www.google.com/",          // referrer
-    FILE_PATH_LITERAL("bla.tmp"),      // tmp_path
-    FILE_PATH_LITERAL("bla.exe"));     // final_path
+      &item, {"http://www.google.com/", download_file_path},  // url_chain
+      "http://www.google.com/",                               // referrer
+      FILE_PATH_LITERAL("bla.tmp"),                           // tmp_path
+      FILE_PATH_LITERAL("bla.dmg"));                          // final_path
+#else
+  PrepareBasicDownloadItem(
+      &item, {"http://www.google.com/", download_file_path},  // url_chain
+      "http://www.google.com/",                               // referrer
+      FILE_PATH_LITERAL("bla.tmp"),                           // tmp_path
+      FILE_PATH_LITERAL("bla.exe"));                          // final_path
+#endif  // OS_MACOSX
+
   std::string remote_address = "10.11.12.13";
   EXPECT_CALL(item, GetRemoteAddress()).WillRepeatedly(Return(remote_address));
-
   EXPECT_CALL(*sb_service_->mock_database_manager(),
               MatchDownloadWhitelistUrl(_))
       .WillRepeatedly(Return(false));
+#if !defined(OS_MACOSX)
   EXPECT_CALL(*binary_feature_extractor_.get(), CheckSignature(tmp_path_, _));
   EXPECT_CALL(*binary_feature_extractor_.get(),
               ExtractImageFeatures(tmp_path_,
                                    BinaryFeatureExtractor::kDefaultOptions,
                                    _, _));
+#endif  // OS_MACOSX
+
   RunLoop run_loop;
   download_service_->CheckClientDownload(
       &item, base::Bind(&DownloadProtectionServiceTest::CheckDoneCallback,
                         base::Unretained(this), run_loop.QuitClosure()));
 
   // Run the message loop(s) until SendRequest is called.
   FlushThreadMessageLoops();
   EXPECT_TRUE(HasClientDownloadRequest());
   ClearClientDownloadRequest();
   net::TestURLFetcher* fetcher = factory.GetFetcherByID(0);
   ASSERT_TRUE(fetcher);
   ClientDownloadRequest request;
   EXPECT_TRUE(request.ParseFromString(fetcher->upload_data()));
-  EXPECT_EQ("ftp://www.google.com/bla.exe", request.url());
+  EXPECT_EQ(download_file_path, request.url());
   EXPECT_EQ(hash_, request.digests().sha256());
   EXPECT_EQ(item.GetReceivedBytes(), request.length());
   EXPECT_EQ(item.HasUserGesture(), request.user_initiated());
   EXPECT_EQ(2, request.resources_size());
   EXPECT_TRUE(RequestContainsResource(request,
                                       ClientDownloadRequest::DOWNLOAD_REDIRECT,
                                       "http://www.google.com/", ""));
   EXPECT_TRUE(RequestContainsResource(request,
                                       ClientDownloadRequest::DOWNLOAD_URL,
-                                      "ftp://www.google.com/bla.exe",
-                                      referrer_.spec()));
+                                      download_file_path, referrer_.spec()));
   EXPECT_TRUE(request.has_signature());
   EXPECT_EQ(0, request.signature().certificate_chain_size());
 
   // Simulate the request finishing.
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE,
       base::BindOnce(&DownloadProtectionServiceTest::SendURLFetchComplete,
                      base::Unretained(this), fetcher));
   run_loop.Run();
 }
@@ skipping 270 matching lines @@
       &item,
       {"http://www.evil.com/bla.exe"},  // url_chain
       "http://www.google.com/",         // referrer
       FILE_PATH_LITERAL("a.tmp"),       // tmp_path
       FILE_PATH_LITERAL("a.exe"));      // final_path
     GURL tab_url("http://www.google.com/tab");
     EXPECT_CALL(item, GetTabUrl()).WillRepeatedly(ReturnRef(tab_url));
     EXPECT_CALL(*sb_service_->mock_database_manager(),
                 MatchDownloadWhitelistUrl(_))
         .WillRepeatedly(Return(false));
+
+#if defined(OS_MACOSX)
+    // Expects that MockDownloadItem will go out of scope while asynchronous
+    // processing is parsing file metadata, and thus ExtractFileOrDmgFeatures()
+    // will return rather than continuing to process the download.
+    EXPECT_CALL(*binary_feature_extractor_.get(), CheckSignature(tmp_path_, _))
+        .Times(0);
+    EXPECT_CALL(*binary_feature_extractor_.get(),
+                ExtractImageFeatures(
+                    tmp_path_, BinaryFeatureExtractor::kDefaultOptions, _, _))
+        .Times(0);
+#else
+    // Expects synchronous processing that continues to extract features from
+    // download even after MockDownloadItem goes out of scope.
     EXPECT_CALL(*binary_feature_extractor_.get(), CheckSignature(tmp_path_, _));
     EXPECT_CALL(*binary_feature_extractor_.get(),
                 ExtractImageFeatures(
                     tmp_path_, BinaryFeatureExtractor::kDefaultOptions, _, _));
+#endif
 
     download_service_->CheckClientDownload(
         &item,
         base::Bind(&DownloadProtectionServiceTest::SyncCheckDoneCallback,
                    base::Unretained(this)));
     // MockDownloadItem going out of scope triggers the OnDownloadDestroyed
     // notification.
   }
 
   EXPECT_TRUE(IsResult(DownloadProtectionService::UNKNOWN));
@@ skipping 472 matching lines @@
       &item, base::Bind(&DownloadProtectionServiceTest::CheckDoneCallback,
                         base::Unretained(this), run_loop.QuitClosure()));
   run_loop.Run();
 
   EXPECT_FALSE(HasClientDownloadRequest());
   // Overriden by flag:
   EXPECT_TRUE(IsResult(DownloadProtectionService::DANGEROUS));
 }
 
 }  // namespace safe_browsing