ios/chrome/browser/ui/browser_view_controller.mm - Issue 2926413004: Cancel dialogs for Tabs when they are removed from their TabModels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2926413004: Cancel dialogs for Tabs when they are removed from their TabModels. (Closed)

Patch Set: Revert to patch #1; DCHECK fix is non-essential and will be in follow-up CL Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/browser_view_controller.mm

diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm

index 6dfaffb36c032fe17b0500efa6baeb8e678b3022..29a430b2bf7b37f8e56dace02223da58952e132f 100644

--- a/ios/chrome/browser/ui/browser_view_controller.mm

+++ b/ios/chrome/browser/ui/browser_view_controller.mm

@@ -4632,6 +4632,9 @@ - (void)tabModel:(TabModel*)model

atIndex:(NSUInteger)index {

[self uninstallDelegatesForTab:tab];

+ // Cancel dialogs for |tab|'s WebState.

+ [self.dialogPresenter cancelDialogForWebState:tab.webState];

// Remove stored native controllers for the tab.

[_nativeControllersForTabIDs removeObjectForKey:tab.tabId];

« no previous file with comments | « no previous file | no next file » | no next file with comments »