Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2926323002: Rewrite byte_stream_channel_test.dart to reflective tests. (Closed)

Created:
3 years, 6 months ago by scheglov
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rewrite byte_stream_channel_test.dart to reflective tests. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f32e9d01b5b2a88e787f6b2848be5651f41c19dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -80 lines) Patch
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 11 chunks +66 lines, -80 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 6 months ago (2017-06-08 18:26:48 UTC) #1
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-06-08 18:45:42 UTC) #2
scheglov
3 years, 6 months ago (2017-06-08 18:54:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f32e9d01b5b2a88e787f6b2848be5651f41c19dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698