Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2326)

Unified Diff: chrome/browser/android/vr_shell/textures/ui_texture.cc

Issue 2926303003: [vr] Fix incorrect negation in font fallback logic. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/vr_shell/textures/ui_texture.cc
diff --git a/chrome/browser/android/vr_shell/textures/ui_texture.cc b/chrome/browser/android/vr_shell/textures/ui_texture.cc
index ef2630dbb34568416757eba26f6961b21d3647ed..8216da5d0c1d62c1bd3021a451f717e9a01ae0fa 100644
--- a/chrome/browser/android/vr_shell/textures/ui_texture.cc
+++ b/chrome/browser/android/vr_shell/textures/ui_texture.cc
@@ -193,11 +193,13 @@ bool UiTexture::GetFontList(int size,
bool found_name = GetFallbackFontNameForChar(default_font, c, "", &name);
if (!found_name)
return false;
- if (name.empty())
+ if (!name.empty())
names.insert(name);
}
- for (const auto& name : names)
+ for (const auto& name : names) {
+ DCHECK(!name.empty());
fonts.push_back(gfx::Font(name, size));
+ }
*font_list = gfx::FontList(fonts);
return true;
}
« no previous file with comments | « no previous file | chrome/browser/android/vr_shell/textures/url_bar_texture_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698