Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 292623003: Cleanup: Remove unnecessary semicolons in url_pattern_set.h. (Closed)

Created:
6 years, 7 months ago by Yeun
Modified:
6 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup: Remove unnecessary semicolons in url_pattern_set.h. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/url_pattern.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Yeun
6 years, 7 months ago (2014-05-23 13:08:49 UTC) #1
Yeun
The CQ bit was checked by lauren.yeun.kim@gmail.com
6 years, 7 months ago (2014-05-23 13:20:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/292623003/1
6 years, 7 months ago (2014-05-23 13:21:02 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 13:21:03 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-23 13:21:03 UTC) #5
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-23 14:53:11 UTC) #6
Yeun
The CQ bit was checked by lauren.yeun.kim@gmail.com
6 years, 7 months ago (2014-05-23 15:13:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lauren.yeun.kim@gmail.com/292623003/1
6 years, 7 months ago (2014-05-23 15:14:14 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 20:01:30 UTC) #9
commit-bot: I haz the power
Change committed as 272605
6 years, 7 months ago (2014-05-23 22:01:25 UTC) #10
Yeun
On 2014/05/23 14:53:11, kalman wrote: > lgtm Thanks so much. I'm excited. I know there ...
6 years, 7 months ago (2014-05-23 22:12:09 UTC) #11
not at google - send to devlin
On 2014/05/23 22:12:09, Yeun wrote: > On 2014/05/23 14:53:11, kalman wrote: > > lgtm > ...
6 years, 7 months ago (2014-05-23 22:14:51 UTC) #12
Yeun
6 years, 7 months ago (2014-05-23 22:21:56 UTC) #13
Message was sent while issue was closed. 
On 2014/05/23 22:14:51, kalman wrote:
> On 2014/05/23 22:12:09, Yeun wrote:
> > On 2014/05/23 14:53:11, kalman wrote:
> > > lgtm
> > 
> > Thanks so much. I'm excited.
> > 
> > I know there are some build fails. But this issue was closed and change
> > committed. I don't know what I have to do. Is it OK?
> > 
> > Regards,
> > Lauren
> 
> Are you getting build failure emails?
> 
> those are by bots that compile and run with multiple patches, and it's very
> likely to be another patch causing the problem, or just flaky tests.

My local build was successful. Thanks for your kind response.

Powered by Google App Engine
This is Rietveld 408576698