Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2926203002: [hot reload] Give a better error message when changing between a regular class and a typedef. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
regis, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[hot reload] Give a better error message when changing between a regular class and a typedef. Fixes #29816 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/092eb33341129d68d43319adcc2c448a397ff05b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
M runtime/vm/isolate_reload_test.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M runtime/vm/object_reload.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-06-07 22:15:06 UTC) #2
regis
lgtm
3 years, 6 months ago (2017-06-07 22:38:55 UTC) #3
rmacnak
3 years, 6 months ago (2017-06-07 23:06:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
092eb33341129d68d43319adcc2c448a397ff05b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698