Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 2926153004: Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHAN… (Closed)

Created:
3 years, 6 months ago by bkonyi
Modified:
3 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHANGELOG.md to announce its removal. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/4b6fa0d5fbd06fdca1db48c49fa31725ef629ac3

Patch Set 1 #

Patch Set 2 : Removed alpnSupported from js runtime patch #

Patch Set 3 : Removed SecurityContext.alpnSupported, as ALPN is now supported on all platforms. Also updated CHAN… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -37 lines) Patch
M CHANGELOG.md View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/secure_socket_patch.dart View 2 chunks +0 lines, -7 lines 0 comments Download
M runtime/bin/secure_socket_unsupported.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/security_context.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/io/security_context.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_socket_alpn_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 6 months ago (2017-06-07 21:59:14 UTC) #2
zra
lgtm after also removing from pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart
3 years, 6 months ago (2017-06-07 22:06:32 UTC) #3
bkonyi
3 years, 6 months ago (2017-06-07 22:16:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4b6fa0d5fbd06fdca1db48c49fa31725ef629ac3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698