Fix a crash since commit 476946

Fix a crash since commit 476946

Use of LOG(FATAL) of ReportFatalErrorInMainThread in file V8Initializer.cpp which potentially caused
crash are changed in commit 476946.

Detailed report: https://clusterfuzz.com/v2/testcase-detail/4983978921820160?noredirect=1

BUG=730001

[gyuyoung, 2017-06-07 12:59:15]

gyuyoung@igalia.com changed reviewers:
+ tkent@chromium.org

[gyuyoung, 2017-06-07 12:59:15]

I've been assigned a ClusterFuzz bug in Bug 730001. Though the crash caused by
below commit, I don't know why it happens. It seems that there is very weird
case in linux ARM environment.

https://chromium.googlesource.com/chromium/src/+/46740f4e99de22f90302e72ca3a9...


I revert the use of LOG(FATAL) at the moment. If someone knows what is more
correct fix, please let me know.

#0 0xd02ce43f  (<unknown module>)
#0 0xda3f64d5 in logging::LogMessage::~LogMessage() base/logging.cc:783:7
#1 0xebaaf866 in blink::ReportFatalErrorInMainThread(char const*, char const*)
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:79:3
#2 0xd5ad552b in ReportApiFailure v8/src/api.cc:410:5
#3 0xd5ad552b in ApiCheck v8/src/api.h:122
#4 0xd5ad552b in v8::Uint8ClampedArray::New(v8::Local<v8::ArrayBuffer>, unsigned
int, unsigned int) v8/src/api.cc:7940
#5 0xed223e7a in blink::DOMTypedArray<WTF::Uint8ClampedArray,
v8::Uint8ClampedArray>::Wrap(v8::Isolate*, v8::Local<v8::Object>)
third_party/WebKit/Source/core/dom/DOMTypedArray.cpp:39:15
#6 0xedca6d0f in ToV8 third_party/WebKit/Source/platform/bindings/ToV8.h:34:19
#7 0xedca6d0f in blink::ImageData::AssociateWithWrapper(v8::Isolate*,
blink::WrapperTypeInfo const*, v8::Local<v8::Object>)
third_party/WebKit/Source/core/html/ImageData.cpp:444
#8 0xe4f81aae in blink::ScriptWrappable::Wrap(v8::Isolate*,
v8::Local<v8::Object>)
third_party/WebKit/Source/platform/bindings/ScriptWrappable.cpp:31:10
#9 0xec068b36 in V8SetReturnValue<v8::FunctionCallbackInfo<v8::Value> >
third_party/WebKit/Source/platform/bindings/V8Binding.h:167:13
#10 0xec068b36 in void
blink::V8SetReturnValue<v8::FunctionCallbackInfo<v8::Value>
>(v8::FunctionCallbackInfo<v8::Value> const&, blink::ScriptWrappable*)
third_party/WebKit/Source/platform/bindings/V8Binding.h:174
#11 0xee999893 in getImageDataMethod
out/Release/gen/blink/bindings/modules/v8/V8CanvasRenderingContext2D.cpp:1987:3
#12 0xee999893 in
blink::V8CanvasRenderingContext2D::getImageDataMethodCallback(v8::FunctionCallbackInfo<v8::Value>
const&)
out/Release/gen/blink/bindings/modules/v8/V8CanvasRenderingContext2D.cpp:2910

[gyuyoung, 2017-06-07 13:00:41]

Description was changed from

==========
Fix a crash since commit 476946

Use of LOG(FATAL) of ReportFatalErrorInMainThread in file V8Initializer.cpp
which potentially caused
crash are changed in commit 476946.

Crash report : https://bugs.chromium.org/p/chromium/issues/detail?id=730001

BUG=730001
==========

to

==========
Fix a crash since commit 476946

Use of LOG(FATAL) of ReportFatalErrorInMainThread in file V8Initializer.cpp
which potentially caused
crash are changed in commit 476946.

Detailed report:
https://clusterfuzz.com/v2/testcase-detail/4983978921820160?noredirect=1

BUG=730001
==========

[tkent, 2017-06-08 02:01:01]

I don't think we need to change the code for this crash.  The crash is intended.
 ClusterFuzz reported as new crash just because the crash message is slightly
changed.

What we should do is only merging Issue 730001 to Issue 529146.

[gyuyoung, 2017-06-08 02:16:06]

On 2017/06/08 02:01:01, tkent wrote:
> I don't think we need to change the code for this crash.  The crash is
intended.
>  ClusterFuzz reported as new crash just because the crash message is slightly
> changed.

Ah, thank you for informing me it.

> What we should do is only merging Issue 730001 to Issue 529146.

I just merge it into Issue 529146. Thanks.