Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: tools/gn/toolchain.cc

Issue 2926013002: Support explicit pools in actions (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/toolchain.cc
diff --git a/tools/gn/toolchain.cc b/tools/gn/toolchain.cc
index 70c6ce06f109bdcef256cd34b7372447f4431c95..5af2ce08bc42eb2b96544082b7fadb253ef6fdaf 100644
--- a/tools/gn/toolchain.cc
+++ b/tools/gn/toolchain.cc
@@ -26,6 +26,7 @@ const char* Toolchain::kToolStamp = "stamp";
const char* Toolchain::kToolCopy = "copy";
const char* Toolchain::kToolCopyBundleData = "copy_bundle_data";
const char* Toolchain::kToolCompileXCAssets = "compile_xcassets";
+const char* Toolchain::kToolAction = "action";
Toolchain::Toolchain(const Settings* settings, const Label& label)
: Item(settings, label),
@@ -59,6 +60,8 @@ Toolchain::ToolType Toolchain::ToolNameToType(const base::StringPiece& str) {
if (str == kToolCopy) return TYPE_COPY;
if (str == kToolCopyBundleData) return TYPE_COPY_BUNDLE_DATA;
if (str == kToolCompileXCAssets) return TYPE_COMPILE_XCASSETS;
+ if (str == kToolAction)
brettw 2017/06/08 18:36:20 Can you format this list of conditions (and the ne
Petr Hosek 2017/06/09 03:24:33 Done, this was done by clang-format.
+ return TYPE_ACTION;
return TYPE_NONE;
}
@@ -79,6 +82,8 @@ std::string Toolchain::ToolTypeToName(ToolType type) {
case TYPE_COPY: return kToolCopy;
case TYPE_COPY_BUNDLE_DATA: return kToolCopyBundleData;
case TYPE_COMPILE_XCASSETS: return kToolCompileXCAssets;
+ case TYPE_ACTION:
+ return kToolAction;
default:
NOTREACHED();
return std::string();

Powered by Google App Engine
This is Rietveld 408576698