Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: tools/gn/action_values.h

Issue 2926013002: Support explicit pools in actions (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/action_values.h
diff --git a/tools/gn/action_values.h b/tools/gn/action_values.h
index 879ccf6ef694a315c820c0d6e3bf5d107436293e..806a39f8c641f78a63b6d7900dc09e33ee96dd87 100644
--- a/tools/gn/action_values.h
+++ b/tools/gn/action_values.h
@@ -9,9 +9,11 @@
#include <vector>
#include "base/macros.h"
+#include "tools/gn/label_ptr.h"
#include "tools/gn/source_file.h"
#include "tools/gn/substitution_list.h"
+class Pool;
class Target;
// Holds the values (outputs, args, script name, etc.) for either an action or
@@ -50,9 +52,9 @@ class ActionValues {
}
bool uses_rsp_file() const { return !rsp_file_contents_.list().empty(); }
- // Console pool option
- bool is_console() const { return console_; }
- void set_console(bool value) { console_ = value; }
+ // Pool option
+ const LabelPtrPair<Pool>& pool() const { return pool_; }
+ void set_pool(LabelPtrPair<Pool> pool) { pool_ = std::move(pool); }
private:
SourceFile script_;
@@ -60,7 +62,7 @@ class ActionValues {
SubstitutionList outputs_;
SubstitutionPattern depfile_;
SubstitutionList rsp_file_contents_;
- bool console_;
+ LabelPtrPair<Pool> pool_;
DISALLOW_COPY_AND_ASSIGN(ActionValues);
};

Powered by Google App Engine
This is Rietveld 408576698