Support explicit pools in actions

tools/gn/toolchain.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/toolchain.h"
 
 #include <stddef.h>
 #include <string.h>
 #include <utility>
 
 #include "base/logging.h"
 #include "tools/gn/target.h"
 #include "tools/gn/value.h"
 
 const char* Toolchain::kToolCc = "cc";
 const char* Toolchain::kToolCxx = "cxx";
 const char* Toolchain::kToolObjC = "objc";
 const char* Toolchain::kToolObjCxx = "objcxx";
 const char* Toolchain::kToolRc = "rc";
 const char* Toolchain::kToolAsm = "asm";
 const char* Toolchain::kToolAlink = "alink";
 const char* Toolchain::kToolSolink = "solink";
 const char* Toolchain::kToolSolinkModule = "solink_module";
 const char* Toolchain::kToolLink = "link";
 const char* Toolchain::kToolStamp = "stamp";
 const char* Toolchain::kToolCopy = "copy";
 const char* Toolchain::kToolCopyBundleData = "copy_bundle_data";
 const char* Toolchain::kToolCompileXCAssets = "compile_xcassets";
+const char* Toolchain::kToolAction = "action";
 
 Toolchain::Toolchain(const Settings* settings, const Label& label)
     : Item(settings, label),
       setup_complete_(false) {
 }
 
 Toolchain::~Toolchain() {
 }
 
 Toolchain* Toolchain::AsToolchain() {
@@ skipping 13 matching lines @@
   if (str == kToolRc) return TYPE_RC;
   if (str == kToolAsm) return TYPE_ASM;
   if (str == kToolAlink) return TYPE_ALINK;
   if (str == kToolSolink) return TYPE_SOLINK;
   if (str == kToolSolinkModule) return TYPE_SOLINK_MODULE;
   if (str == kToolLink) return TYPE_LINK;
   if (str == kToolStamp) return TYPE_STAMP;
   if (str == kToolCopy) return TYPE_COPY;
   if (str == kToolCopyBundleData) return TYPE_COPY_BUNDLE_DATA;
   if (str == kToolCompileXCAssets) return TYPE_COMPILE_XCASSETS;
+  if (str == kToolAction)

[brettw, 2017/06/08 18:36:20]

Can you format this list of conditions (and the next one) consistently? If clang
wants to put them on separate lines, that's OK, though I prefer single-line
otherwise.

[Petr Hosek, 2017/06/09 03:24:33]

Done, this was done by clang-format.

+    return TYPE_ACTION;
   return TYPE_NONE;
 }
 
 // static
 std::string Toolchain::ToolTypeToName(ToolType type) {
   switch (type) {
     case TYPE_CC: return kToolCc;
     case TYPE_CXX: return kToolCxx;
     case TYPE_OBJC: return kToolObjC;
     case TYPE_OBJCXX: return kToolObjCxx;
     case TYPE_RC: return kToolRc;
     case TYPE_ASM: return kToolAsm;
     case TYPE_ALINK: return kToolAlink;
     case TYPE_SOLINK: return kToolSolink;
     case TYPE_SOLINK_MODULE: return kToolSolinkModule;
     case TYPE_LINK: return kToolLink;
     case TYPE_STAMP: return kToolStamp;
     case TYPE_COPY: return kToolCopy;
     case TYPE_COPY_BUNDLE_DATA: return kToolCopyBundleData;
     case TYPE_COMPILE_XCASSETS: return kToolCompileXCAssets;
+    case TYPE_ACTION:
+      return kToolAction;
     default:
       NOTREACHED();
       return std::string();
   }
 }
 
 Tool* Toolchain::GetTool(ToolType type) {
   DCHECK(type != TYPE_NONE);
   return tools_[static_cast<size_t>(type)].get();
 }
@@ skipping 77 matching lines @@
       return TYPE_STAMP;
     default:
       NOTREACHED();
       return Toolchain::TYPE_NONE;
   }
 }
 
 const Tool* Toolchain::GetToolForTargetFinalOutput(const Target* target) const {
   return tools_[GetToolTypeForTargetFinalOutput(target)].get();
 }