Polymer: Remove <paper-material> from polymer_resources.grdp file.

tools/polymer/polymer_grdp_to_txt.py

Index: tools/polymer/polymer_grdp_to_txt.py
diff --git a/tools/polymer/polymer_grdp_to_txt.py b/tools/polymer/polymer_grdp_to_txt.py
index 9940faa36de29f706259df846b0e4e70f34174d0..852a2d3ac59abedee59f4cac92a743b0ebcebc43 100755
--- a/tools/polymer/polymer_grdp_to_txt.py
+++ b/tools/polymer/polymer_grdp_to_txt.py
@@ -3,6 +3,8 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from itertools import chain
+from os import path as os_path
 import sys
 import xml.sax
 
@@ -12,6 +14,19 @@ class PathsExtractor(xml.sax.ContentHandler):
   def __init__(self):
     self.paths = []
 
+    # Following elements are not used anymore, but are unfortunately downloaded

[michaelpg, 2017/06/07 05:44:07]

Can you clarify what your purpose is in adding this check? The grdp file is not
auto-generated from third_party/polymer, so it looks like you're trying to avoid
human error.

This just removes the blacklisted files from the text output when I run
polymer_grdp_to_txt.py. It doesn't prevent me from adding the files to the .grdp
directly.

Nor does it prevent me from adding these files when I do this (this is how I
normally add elements btw):

1. polymer_grdp_to_txt.py ui/webui/resources/polymer_resources.grdp >
elements.txt
2. vim elements.txt # add/remove what I want
3. txt_to_polymer_grdp.py > ui/webui/resources/polymer_resources.grdp

[dpapad, 2017/06/07 17:19:14]

What I had in mind was that if someone runs 1,2,3 without doing any manual
editing, they would get a grdp file that does not have any obsoleted elements.

To be honest, I don't understand why any manual editing is needed, and
consequently why the grdp file is not automatically updated as part of
reproduce.sh. Adding to my confusion, the instructions about steps 1,2,3 are
only displayed within polymer_resources.grdp, which means that whoever runs
reproduce.sh needs to know beforehand that they also need to update that file. I
would expect reproduce.sh to at least print instructions in the output of manual
steps need to be taken by someone rolling Polymer elements.

[dpapad, 2017/06/07 20:44:45]

Resolved per offline discussion with michaelpg@, by reverting the change to this
file.

+    # because they co-reside in the same GitHub repository with elements that
+    # are still used. Adding them in this blacklist will prevent such elements
+    # from being included in the final polymer_resources.grdp file.
+    blacklisted_elements = [
+        'paper-material'
+    ]
+
+    self.blacklist = list(chain(*map(
+        lambda dep: map(
+            lambda suffix: dep + suffix, ['.html', '-extracted.js']),
+        blacklisted_elements)))
+
   def startElement(self, name, attrs):
     if name != 'structure':
       return
@@ -20,6 +35,8 @@ class PathsExtractor(xml.sax.ContentHandler):
       return
     prefix_1_0 = '../../../third_party/polymer/v1_0/components-chromium/'
     if path.startswith(prefix_1_0):
+      if os_path.basename(path) in self.blacklist:
+        return
       self.paths.append(path[len(prefix_1_0):])
     else:
       raise Exception("Unexpected path %s." % path)