Migrate upgrade notifications to observer

chrome/browser/upgrade_detector.h

Index: chrome/browser/upgrade_detector.h
diff --git a/chrome/browser/upgrade_detector.h b/chrome/browser/upgrade_detector.h
index 3936606c57be0a8dd409ad513ffba09ca7be92d6..a1134b1e046838457b7a5047f151280660f17817 100644
--- a/chrome/browser/upgrade_detector.h
+++ b/chrome/browser/upgrade_detector.h
@@ -9,7 +9,6 @@
 #include "base/macros.h"
 #include "base/observer_list.h"
 #include "base/timer/timer.h"
-#include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/upgrade_observer.h"
 #include "ui/base/idle/idle.h"
 #include "ui/gfx/image/image.h"
@@ -86,6 +85,13 @@ class UpgradeDetector {
 
   void RemoveObserver(UpgradeObserver* observer);
 
+  // Notifies that the current install is outdated. No details are expected.
+  void NotifyOutdatedInstall();

[sky, 2017/06/07 23:01:42]

Why do the notify functions need to be public?

[weidongg, 2017/06/08 02:28:42]

browser_commands.cc needs to notify upgrade to the observers. Should I make them
protected and add BrowserCommand as a friend class?

+
+  // Notifies that the current install is outdated and auto-update (AU) is

[sky, 2017/06/07 23:01:42]

I realize it's long, but go with AutoUpdate. au is cryptic.

[weidongg, 2017/06/08 02:28:42]

Done.

+  // disabled. No details are expected.
+  void NotifyOutdatedInstallNoAU();
+
  protected:
   enum UpgradeAvailable {
     // If no update is available and current install is recent enough.
@@ -105,9 +111,17 @@ class UpgradeDetector {
 
   UpgradeDetector();
 
-  // Sends out UPGRADE_RECOMMENDED notification and set notify_upgrade_.
+  // Notifies that update is recommended and triggers different actions based
+  // on the update availability.
+  void NotifyUpgrade();
+
+  // Notifies that update is recommended.
   void NotifyUpgradeRecommended();
 
+  // Notifies that a critical update has been installed. No details are
+  // expected.
+  void NotifyCriticalUpgradeInstalled();
+
   // The function that sends out a notification that lets the rest of the UI
   // know we should notify the user that a new update is available to download
   // over cellular connection.
@@ -156,9 +170,6 @@ class UpgradeDetector {
   // input events since the specified time.
   void IdleCallback(ui::IdleState state);
 
-  // Triggers a global notification of the specified |type|.
-  void TriggerNotification(chrome::NotificationType type);
-
   // Whether any software updates are available (experiment updates are tracked
   // separately via additional member variables below).
   UpgradeAvailable upgrade_available_;