Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3691)

Unified Diff: chrome/browser/ui/webui/settings/about_handler.h

Issue 2925973002: Migrate upgrade notifications to observer (Closed)
Patch Set: Fix test failure Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/about_handler.h
diff --git a/chrome/browser/ui/webui/settings/about_handler.h b/chrome/browser/ui/webui/settings/about_handler.h
index 5dc9d2331b3fbb9add5981952b939a139f5bdd98..cc0d643edea967b18883b46a9c880572938f3e22 100644
--- a/chrome/browser/ui/webui/settings/about_handler.h
+++ b/chrome/browser/ui/webui/settings/about_handler.h
@@ -15,9 +15,8 @@
#include "build/build_config.h"
#include "chrome/browser/ui/webui/help/version_updater.h"
#include "chrome/browser/ui/webui/settings/settings_page_ui_handler.h"
+#include "chrome/browser/upgrade_observer.h"
#include "components/policy/core/common/policy_service.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_ui_message_handler.h"
#if defined(OS_CHROMEOS)
@@ -41,7 +40,7 @@ namespace settings {
// WebUI message handler for the help page.
class AboutHandler : public settings::SettingsPageUIHandler,
- public content::NotificationObserver {
+ public UpgradeObserver {
public:
AboutHandler();
~AboutHandler() override;
@@ -54,10 +53,8 @@ class AboutHandler : public settings::SettingsPageUIHandler,
void OnJavascriptAllowed() override;
void OnJavascriptDisallowed() override;
- // NotificationObserver implementation.
- void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ // UpgradeObserver implementation.
+ void OnUpgradeRecommended() override;
// Returns the browser version as a string.
static base::string16 BuildBrowserVersionString();
@@ -151,9 +148,6 @@ class AboutHandler : public settings::SettingsPageUIHandler,
// Specialized instance of the VersionUpdater used to update the browser.
std::unique_ptr<VersionUpdater> version_updater_;
- // Used to observe notifications.
- content::NotificationRegistrar registrar_;
-
// Used to observe changes in the |kDeviceAutoUpdateDisabled| policy.
std::unique_ptr<policy::PolicyChangeRegistrar> policy_registrar_;

Powered by Google App Engine
This is Rietveld 408576698