Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/upgrade_detector.h

Issue 2925973002: Migrate upgrade notifications to observer (Closed)
Patch Set: Add DISALLOW_COPY_AND_ASSIGN Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/about_handler.cc ('k') | chrome/browser/upgrade_detector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/upgrade_detector.h
diff --git a/chrome/browser/upgrade_detector.h b/chrome/browser/upgrade_detector.h
index 3936606c57be0a8dd409ad513ffba09ca7be92d6..fce8e2f7f2533852a44fd8eb1d3f4c985728ec25 100644
--- a/chrome/browser/upgrade_detector.h
+++ b/chrome/browser/upgrade_detector.h
@@ -9,7 +9,6 @@
#include "base/macros.h"
#include "base/observer_list.h"
#include "base/timer/timer.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/upgrade_observer.h"
#include "ui/base/idle/idle.h"
#include "ui/gfx/image/image.h"
@@ -86,6 +85,13 @@ class UpgradeDetector {
void RemoveObserver(UpgradeObserver* observer);
+ // Notifies that the current install is outdated. No details are expected.
+ void NotifyOutdatedInstall();
+
+ // Notifies that the current install is outdated and auto-update (AU) is
+ // disabled. No details are expected.
+ void NotifyOutdatedInstallNoAutoUpdate();
+
protected:
enum UpgradeAvailable {
// If no update is available and current install is recent enough.
@@ -105,9 +111,17 @@ class UpgradeDetector {
UpgradeDetector();
- // Sends out UPGRADE_RECOMMENDED notification and set notify_upgrade_.
+ // Notifies that update is recommended and triggers different actions based
+ // on the update availability.
+ void NotifyUpgrade();
+
+ // Notifies that update is recommended.
void NotifyUpgradeRecommended();
+ // Notifies that a critical update has been installed. No details are
+ // expected.
+ void NotifyCriticalUpgradeInstalled();
+
// The function that sends out a notification that lets the rest of the UI
// know we should notify the user that a new update is available to download
// over cellular connection.
@@ -156,9 +170,6 @@ class UpgradeDetector {
// input events since the specified time.
void IdleCallback(ui::IdleState state);
- // Triggers a global notification of the specified |type|.
- void TriggerNotification(chrome::NotificationType type);
-
// Whether any software updates are available (experiment updates are tracked
// separately via additional member variables below).
UpgradeAvailable upgrade_available_;
« no previous file with comments | « chrome/browser/ui/webui/settings/about_handler.cc ('k') | chrome/browser/upgrade_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698