chrome/browser/ui/toolbar/app_menu_model_unittest.cc - Issue 2925973002: Migrate upgrade notifications to observer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/app_menu_model_unittest.cc

Issue 2925973002: Migrate upgrade notifications to observer (Closed)

Patch Set: Add DISALLOW_COPY_AND_ASSIGN Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/app_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/app_menu_model_unittest.cc b/chrome/browser/ui/toolbar/app_menu_model_unittest.cc

index af9e915f18046e303566c22caab90a700faa2e6f..df9bb75100674120975ae5b022a763f42ebeaf0e 100644

--- a/chrome/browser/ui/toolbar/app_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/app_menu_model_unittest.cc

@@ -127,7 +127,7 @@ TEST_F(AppMenuModelTest, Basics) {

EXPECT_GT(itemCount, 10);

UpgradeDetector* detector = UpgradeDetector::GetInstance();

- detector->NotifyUpgradeRecommended();

+ detector->NotifyUpgrade();

EXPECT_TRUE(detector->notify_upgrade());

EXPECT_EQ(browser_defaults::kShowUpgradeMenuItem,

model.IsCommandIdVisible(IDC_UPGRADE_DIALOG));