Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2925973002: Migrate upgrade notifications to observer (Closed)
Patch Set: Add DISALLOW_COPY_AND_ASSIGN Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 54582710f9eeabe66591d594472edeb84fde23ee..72c580bf0f1c43afed2f7e02ed7166001ee22756 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -14,7 +14,6 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browsing_data/browsing_data_helper.h"
#include "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.h"
-#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/dom_distiller/tab_utils.h"
#include "chrome/browser/lifetime/application_lifetime.h"
@@ -75,7 +74,6 @@
#include "content/public/browser/devtools_agent_host.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
-#include "content/public/browser/notification_service.h"
#include "content/public/browser/page_navigator.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/render_widget_host_view.h"
@@ -1139,15 +1137,9 @@ void ShowAvatarMenu(Browser* browser) {
void OpenUpdateChromeDialog(Browser* browser) {
if (UpgradeDetector::GetInstance()->is_outdated_install()) {
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_OUTDATED_INSTALL,
- content::NotificationService::AllSources(),
- content::NotificationService::NoDetails());
+ UpgradeDetector::GetInstance()->NotifyOutdatedInstall();
} else if (UpgradeDetector::GetInstance()->is_outdated_install_no_au()) {
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_OUTDATED_INSTALL_NO_AU,
- content::NotificationService::AllSources(),
- content::NotificationService::NoDetails());
+ UpgradeDetector::GetInstance()->NotifyOutdatedInstallNoAutoUpdate();
} else {
base::RecordAction(UserMetricsAction("UpdateChrome"));
browser->window()->ShowUpdateChromeDialog();
« no previous file with comments | « chrome/browser/ui/ash/system_tray_client_browsertest.cc ('k') | chrome/browser/ui/toolbar/app_menu_icon_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698